Return-Path: X-Original-To: apmail-ambari-dev-archive@www.apache.org Delivered-To: apmail-ambari-dev-archive@www.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 53E51177B1 for ; Mon, 6 Oct 2014 22:11:33 +0000 (UTC) Received: (qmail 63750 invoked by uid 500); 6 Oct 2014 22:11:33 -0000 Delivered-To: apmail-ambari-dev-archive@ambari.apache.org Received: (qmail 63721 invoked by uid 500); 6 Oct 2014 22:11:33 -0000 Mailing-List: contact dev-help@ambari.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@ambari.apache.org Delivered-To: mailing list dev@ambari.apache.org Received: (qmail 63697 invoked by uid 99); 6 Oct 2014 22:11:32 -0000 Received: from reviews-vm.apache.org (HELO reviews.apache.org) (140.211.11.40) by apache.org (qpsmtpd/0.29) with ESMTP; Mon, 06 Oct 2014 22:11:32 +0000 Received: from reviews.apache.org (localhost [127.0.0.1]) by reviews.apache.org (Postfix) with ESMTP id 61F511DDCD1; Mon, 6 Oct 2014 22:11:29 +0000 (UTC) Content-Type: multipart/alternative; boundary="===============7355316824536806074==" MIME-Version: 1.0 Subject: Re: Review Request 26386: Views : View API request for non-existent view should return 404 From: "Alejandro Fernandez" To: "Alejandro Fernandez" , "Nate Cole" Cc: "Ambari" , "Tom Beerbower" Date: Mon, 06 Oct 2014 22:11:29 -0000 Message-ID: <20141006221129.24817.40899@reviews.apache.org> X-ReviewBoard-URL: https://reviews.apache.org Auto-Submitted: auto-generated Sender: "Alejandro Fernandez" X-ReviewGroup: Ambari X-ReviewRequest-URL: https://reviews.apache.org/r/26386/ X-Sender: "Alejandro Fernandez" References: <20141006215512.24818.85501@reviews.apache.org> In-Reply-To: <20141006215512.24818.85501@reviews.apache.org> Reply-To: "Alejandro Fernandez" X-ReviewRequest-Repository: ambari --===============7355316824536806074== MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/26386/#review55586 ----------------------------------------------------------- Ship it! Ship It! - Alejandro Fernandez On Oct. 6, 2014, 9:55 p.m., Tom Beerbower wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/26386/ > ----------------------------------------------------------- > > (Updated Oct. 6, 2014, 9:55 p.m.) > > > Review request for Ambari, Alejandro Fernandez and Nate Cole. > > > Bugs: AMBARI-7664 > https://issues.apache.org/jira/browse/AMBARI-7664 > > > Repository: ambari > > > Description > ------- > > The request ... > > {code} > GET http://c6401.ambari.apache.org:8080/api/v1/views/BadView > {code} > > ... where 'BadView' is not a deployed view, should return a 404. > > {code} > { > "status" : 404, > "message" : "The requested resource doesn't exist: View not found, ViewInfo/view_name=BadView" > } > {code} > > > Diffs > ----- > > ambari-server/src/main/java/org/apache/ambari/server/controller/internal/ClusterControllerImpl.java 48767d5 > ambari-server/src/test/java/org/apache/ambari/server/controller/internal/ClusterControllerImplTest.java 1d0eef4 > > Diff: https://reviews.apache.org/r/26386/diff/ > > > Testing > ------- > > Manual tests. > > New unit test added. All existing tests pass ... > > > Results : > > Tests run: 2077, Failures: 0, Errors: 0, Skipped: 16 > ... > [INFO] Executed tasks > [INFO] ------------------------------------------------------------------------ > [INFO] BUILD SUCCESS > [INFO] ------------------------------------------------------------------------ > [INFO] Total time: 31:31.433s > [INFO] Finished at: Mon Oct 06 17:41:47 EDT 2014 > [INFO] Final Memory: 38M/476M > [INFO] ------------------------------------------------------------------------ > > > Thanks, > > Tom Beerbower > > --===============7355316824536806074==--