Mailing-List: contact dev-help@ambari.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@ambari.apache.org
Content-Type: multipart/alternative;
 boundary="===============2981331572024424077=="
MIME-Version: 1.0
Subject: Re: Review Request 26194: Admin : ambari-server sync-ldap - support
 --existing, --users & --groups options
From: "Tom Beerbower" <tbeerbower@hortonworks.com>
To: "Nate Cole" <ncole@hortonworks.com>,
 "Jonathan Hurley" <jhurley@hortonworks.com>
Cc: "Ambari" <dev@ambari.apache.org>,
 "Tom Beerbower" <tbeerbower@hortonworks.com>
Date: Wed, 01 Oct 2014 12:57:12 -0000
Message-ID: <20141001125712.19177.91874@reviews.apache.org>
Auto-Submitted: auto-generated
Sender: "Tom Beerbower" <noreply@reviews.apache.org>
References: <20141001124312.19177.25973@reviews.apache.org>
In-Reply-To: <20141001124312.19177.25973@reviews.apache.org>
Reply-To: "Tom Beerbower" <tbeerbower@hortonworks.com>

--===============2981331572024424077==
MIME-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 7bit


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/26194/
-----------------------------------------------------------

(Updated Oct. 1, 2014, 12:57 p.m.)


Review request for Ambari, Jonathan Hurley and Nate Cole.


Changes
-------

More review changes


Bugs: AMBARI-7569
    https://issues.apache.org/jira/browse/AMBARI-7569


Repository: ambari


Description
-------

The command line 'ambari-server sync-ldap' should support the options as follows ...

{quote}
"ambari-server sync-ldap --existing" which would would first look at the ambari database and only clean-up those users and groups. This way, it doesn't pull any new ones, it a) removes users that are in ambari but out of ldap, b) remove groups that are in ambari but out of ldap and c) syncs the group membership of the groups that are in ambari

"ambari-server sync-ldap --users users.txt --groups groups.txt" which would allow people to just sync a specific set of users and groups from ldap to ambari. The .txt files would be the user and group ids to sync into ambari. This is going to be important for people that just want to bring "a specific set" of users + groups into ambari from ldap (not the "all"). And then once this has happened, running with --existing option periodically helps keep these "in sync"
{quote}


Diffs (updated)
-----

  ambari-server/sbin/ambari-server 027bf87 
  ambari-server/src/main/python/ambari-server.py 9059319 
  ambari-server/src/test/python/TestAmbariServer.py 7f769f1 

Diff: https://reviews.apache.org/r/26194/diff/


Testing
-------

Results :

Tests run: 2076, Failures: 0, Errors: 0, Skipped: 16

...

[INFO] Executed tasks
[INFO] ------------------------------------------------------------------------
[INFO] BUILD SUCCESS
[INFO] ------------------------------------------------------------------------
[INFO] Total time: 33:19.993s
[INFO] Finished at: Tue Sep 30 17:15:25 EDT 2014
[INFO] Final Memory: 38M/293M
[INFO] ------------------------------------------------------------------------


Thanks,

Tom Beerbower


--===============2981331572024424077==--