ambari-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Hadoop QA (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (AMBARI-7893) Slider View: Updating view params in UI breaks masked params
Date Wed, 22 Oct 2014 04:03:34 GMT

    [ https://issues.apache.org/jira/browse/AMBARI-7893?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14179546#comment-14179546
] 

Hadoop QA commented on AMBARI-7893:
-----------------------------------

{color:red}-1 overall{color}.  Here are the results of testing the latest attachment 
  http://issues.apache.org/jira/secure/attachment/12676253/AMBARI-7893.patch
  against trunk revision .

    {color:green}+1 @author{color}.  The patch does not contain any @author tags.

    {color:red}-1 tests included{color}.  The patch doesn't appear to include any new or modified
tests.
                        Please justify why no new tests are needed for this patch.
                        Also please list what manual steps were performed to verify this patch.

    {color:green}+1 javac{color}.  The applied patch does not increase the total number of
javac compiler warnings.

    {color:green}+1 release audit{color}.  The applied patch does not increase the total number
of release audit warnings.

    {color:green}+1 core tests{color}.  The patch passed unit tests in ambari-admin.

Test results: https://builds.apache.org/job/Ambari-trunk-test-patch/295//testReport/
Console output: https://builds.apache.org/job/Ambari-trunk-test-patch/295//console

This message is automatically generated.

> Slider View: Updating view params in UI breaks masked params
> ------------------------------------------------------------
>
>                 Key: AMBARI-7893
>                 URL: https://issues.apache.org/jira/browse/AMBARI-7893
>             Project: Ambari
>          Issue Type: Bug
>          Components: ambari-admin
>    Affects Versions: 1.7.0
>            Reporter: Andrii Tkach
>            Assignee: Andrii Tkach
>            Priority: Critical
>             Fix For: 1.7.0
>
>         Attachments: AMBARI-7893.patch
>
>
> I created a slider view in the Ambari-Admin UI. The view had one masked parameter {{ambari.server.password}}.
I entered "admin" and saw in the POST that the decoded value was uploaded:
> {code}
> {
>   "ViewInstanceInfo": {
>     "instance_name": "s2",
>     "label": "s2",
>     "visible": true,
>     "icon_path": "",
>     "icon64_path": "",
>     "properties": {
>       "ambari.server.url": "http://tdk-1:8080/api/c1/clusters/tdk",
>       "ambari.server.username": "admin",
>       "ambari.server.password": "admin",
>       "view.kerberos.principal": "a",
>       "view.kerberos.principal.keytab": "aa"
>     },
>     "description": "s2"
>   }
> }
> {code}
> After saved, I editing and changed another param (say view.kerberos.principal). This
broke the masked param. The reason is that the GET call to view parameters gives the encoded
value.
> So POST takes decoded values and GET provides encoded values. So the next time UI PUTs,
the encoded value is put resulting in original value corruption.
> The API should either always provided encoded or decoded values, but not both.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message