ambari-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Jaimin D Jetly (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (AMBARI-7354) Allow different stack have different predefined site properties
Date Wed, 15 Oct 2014 02:48:33 GMT

    [ https://issues.apache.org/jira/browse/AMBARI-7354?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14171915#comment-14171915
] 

Jaimin D Jetly commented on AMBARI-7354:
----------------------------------------

[~u39kun] [~mjshi] [~rmeneses]

Patch looks good to me. It should work for both HDP and BIGTOP stacks

The only thing that  concerns me is the data redundancy. I do believe that the stack owners
should have complete control on the file properties of the stack. Bit I
feel stack should be the only place where the stack proprietary metainfo should exist and
Stack should be the single source of truth.

Unfortunately some properties (only few database options related properties for hive and oozie)
are defined in the ambari-web predefined properties and not in the stack.

Our real goal should be to have all properties that are required by the agent to be defined
only in the stack and nothing new should be defined in the web predefined properties file.
 This will eliminate the need of one predefined site properties per stack. With the proper
refactoring in the [code | https://git-wip-us.apache.org/repos/asf/ambari/repo?p=ambari.git;a=blob;f=ambari-web/app/utils/config.js;h=b31c5ad8364d6b679464698c5a4a7edb23900b4e;hb=HEAD#l454],
we can also eliminate the need of a one predefined site properties per stack version. Eventually
the web should have only one file for site_properties.

I also understand the need of a new property in the stack for every service that requires
database (Hive and Oozie as of now) which will signify the default option for a service database.
For example the value of this new  property for hive will be "New MySQL database" for HDP
stack and "New PostgreSQL database" for BIGTOP stack.

Please comment with your views on this proposal. If this ticket is an urgent fix required
for BIGTOP deployment then we can go with this fix for 1.7.0 version and create another task
to address the same issue in Ambari-2.0.0 version. We can move our further discussion on the
new jira after your initial comments about the proposal on this ticket.

> Allow different stack have different predefined site properties
> ---------------------------------------------------------------
>
>                 Key: AMBARI-7354
>                 URL: https://issues.apache.org/jira/browse/AMBARI-7354
>             Project: Ambari
>          Issue Type: Improvement
>          Components: ambari-web
>    Affects Versions: 1.7.0
>            Reporter: Mingjiang Shi
>            Assignee: Rodrigo Meneses
>             Fix For: 1.7.0, 2.0.0
>
>         Attachments: AMBR-151.diff.trunk.patch
>
>
> Ambari right now supports different site_properties for Hadoop2Stack and nonHadoopStack,
see code below:
> {code}
>   preDefinedSiteProperties: function () {
>     if (App.get('isHadoop2Stack')) {
>       return require('data/HDP2/site_properties').configProperties;
>     }
>     return require('data/site_properties').configProperties;
>   }.property('App.isHadoop2Stack'),
> {code}
> In some case, different stacks and different stack version may require different site_property,
like the PHD stack may use "New PostgreSQL Database" for hive metastore while HDP uses "New
MySQL Database". Therefore, Ambari should allow different stack has different site properties
file. 



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message