ambari-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From jun aoki <ja...@apache.org>
Subject Re: PROPOSAL: Ambari dev process.
Date Thu, 02 Oct 2014 04:32:57 GMT
Thank you Yusaku for sharing your preference.
git diff & git apply combination probably is more straightforward.
How about others?
I'd like to agree upon it and start enforcing it so that we will see more
accurate test-patch results.
(You've seen patch-can-not-be-applied errors from Hadoop QA)


On Wed, Oct 1, 2014 at 3:21 PM, Yusaku Sako <yusaku@hortonworks.com> wrote:

> +1.  I like #1.
>
> Yusaku
>
> On Wed, Oct 1, 2014 at 3:17 PM, jun aoki <jaoki@apache.org> wrote:
>
> > I have added another comment to the process proposal doc regarding how to
> > make a patch
> >
> >
> https://docs.google.com/a/pivotal.io/document/d/1hz7qjGKkNeckMibEs67ZmAa2kxjie0zkG6H_IiC2RgA/edit
> >
> > There are 2 major ways to make a patch with git.
> > 1. git diff trunk... > a.patch  # --> git apply a.patch
> > 2. git format-patch > a.patch # --> patch -p0 < a.patch.
> >
> > I prefer 1) because the git command does all, and proposed it in the doc.
> > Please let me know your feedback on the doc. If you are OK with it.
> >
> >
> > On Tue, Sep 30, 2014 at 11:59 AM, Yusaku Sako <yusaku@hortonworks.com>
> > wrote:
> >
> > > Hi Jun,
> > >
> > > Here is the wiki for the dev process on new major features:
> > >
> >
> https://cwiki.apache.org/confluence/display/AMBARI/Development+Process+for+New+Major+Features
> > >
> > > Yusaku
> > >
> > > On Tue, Sep 30, 2014 at 11:47 AM, jun aoki <jaoki@apache.org> wrote:
> > >
> > >> Hi Sumit/Yusaku,
> > >>
> > >> Sumit left a godo feedback.
> > >> >> If its a new feature then we should expect some design discussion
> on
> > >> the JIRA before or along with the patch.
> > >>
> > >> I remember the community (I believe Yusaku, you started enforcing)
> have
> > a
> > >> process for Ambari Epics.
> > >> Do we have a wiki page for it that I can link in the proposal doc?
> > >>
> > >>
> > >> The proposal
> > >>
> > >>
> >
> https://docs.google.com/a/pivotal.io/document/d/1hz7qjGKkNeckMibEs67ZmAa2kxjie0zkG6H_IiC2RgA/edit
> > >>
> > >>
> > >> On Tue, Sep 30, 2014 at 9:29 AM, jun aoki <jaoki@apache.org> wrote:
> > >>
> > >>> We have got some good feedback on the doc. Thank you and keep it
> > coming!
> > >>> Due date is till 10/5.
> > >>>
> > >>> Give a +1 on someone's comment so that I can see the popularity too!
> > >>>
> > >>> >> Should we keep comments/discussions on the Google doc itself?
> > >>> Yusaku, yes we can. But let me know if you have a better idea.
> > >>>
> > >>>
> > >>> On Mon, Sep 29, 2014 at 10:25 PM, Yusaku Sako <
> yusaku@hortonworks.com>
> > >>> wrote:
> > >>>
> > >>>> Thanks Jun for putting this together.  Very nice.
> > >>>> I've added my comments.
> > >>>> Should we keep comments/discussions on the Google doc itself?
> > >>>>
> > >>>> Yusaku
> > >>>>
> > >>>> On Mon, Sep 29, 2014 at 9:45 PM, jun aoki <jaoki@apache.org>
wrote:
> > >>>>
> > >>>> > Hi Ambari developers,
> > >>>> >
> > >>>> > I have made a proposal of the Ambari development process.
> > >>>> >
> > >>>> >
> > >>>> >
> > >>>>
> >
> https://docs.google.com/a/pivotal.io/document/d/1hz7qjGKkNeckMibEs67ZmAa2kxjie0zkG6H_IiC2RgA/edit
> > >>>> >
> > >>>> > Many things are copied from other Hadoop projects and I have
got
> > some
> > >>>> > feedback from our Pivotal open source developers.
> > >>>> > Please feel free to add your comments and feedbacks to the
> document
> > >>>> > directly
> > >>>> > say, one week from today 10/5 (Let me know if it is too
> aggressive.
> > )
> > >>>> > Then let us go through if the process makes sense to our Ambari
> > >>>> project.
> > >>>> >
> > >>>> > Thank you,
> > >>>> > jun
> > >>>> >
> > >>>>
> > >>>> --
> > >>>> CONFIDENTIALITY NOTICE
> > >>>> NOTICE: This message is intended for the use of the individual
or
> > >>>> entity to
> > >>>> which it is addressed and may contain information that is
> > confidential,
> > >>>> privileged and exempt from disclosure under applicable law. If
the
> > >>>> reader
> > >>>> of this message is not the intended recipient, you are hereby
> notified
> > >>>> that
> > >>>> any printing, copying, dissemination, distribution, disclosure
or
> > >>>> forwarding of this communication is strictly prohibited. If you
have
> > >>>> received this communication in error, please contact the sender
> > >>>> immediately
> > >>>> and delete it from your system. Thank You.
> > >>>>
> > >>>
> > >>>
> > >>
> > >
> > > CONFIDENTIALITY NOTICE
> > > NOTICE: This message is intended for the use of the individual or
> entity
> > > to which it is addressed and may contain information that is
> > confidential,
> > > privileged and exempt from disclosure under applicable law. If the
> reader
> > > of this message is not the intended recipient, you are hereby notified
> > that
> > > any printing, copying, dissemination, distribution, disclosure or
> > > forwarding of this communication is strictly prohibited. If you have
> > > received this communication in error, please contact the sender
> > immediately
> > > and delete it from your system. Thank You.
> > >
> >
> >
> >
> > --
> > -jun
> >
>
> --
> CONFIDENTIALITY NOTICE
> NOTICE: This message is intended for the use of the individual or entity to
> which it is addressed and may contain information that is confidential,
> privileged and exempt from disclosure under applicable law. If the reader
> of this message is not the intended recipient, you are hereby notified that
> any printing, copying, dissemination, distribution, disclosure or
> forwarding of this communication is strictly prohibited. If you have
> received this communication in error, please contact the sender immediately
> and delete it from your system. Thank You.
>



-- 
-jun

Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message