ambari-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Alejandro Fernandez" <afernan...@hortonworks.com>
Subject Review Request 27400: Version comparison fails for GlusterFS
Date Thu, 30 Oct 2014 23:19:16 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/27400/
-----------------------------------------------------------

Review request for Ambari, Jaimin Jetly, Sumit Mohanty, Srimanth Gunturi, Sid Wagle, and Yusaku
Sako.


Bugs: AMBARI-8054
    https://issues.apache.org/jira/browse/AMBARI-8054


Repository: ambari


Description
-------

When installing a cluster with GlusterFS stack, the version comparison fails.

```
Traceback (most recent call last):
File "/var/lib/ambari-agent/cache/stacks/HDP/2.0.6/services/HIVE/package/scripts/hive_client.py",
line 42, in <module>
HiveClient().execute()
File "/usr/lib/python2.6/site-packages/resource_management/libraries/script/script.py", line
122, in execute
method(env)
File "/var/lib/ambari-agent/cache/stacks/HDP/2.0.6/services/HIVE/package/scripts/hive_client.py",
line 27, in install
import params
File "/var/lib/ambari-agent/cache/stacks/HDP/2.0.6/services/HIVE/package/scripts/params.py",
line 32, in <module>
hdp_stack_version = format_hdp_stack_version(hdp_stack_version)
File "/usr/lib/python2.6/site-packages/resource_management/libraries/functions/version.py",
line 43, in format_hdp_stack_version
normalized = _normalize(str(input))
File "/usr/lib/python2.6/site-packages/resource_management/libraries/functions/version.py",
line 34, in _normalize
return [int(x) for x in v_list]
ValueError: invalid literal for int() with base 10: 'GlusterFS'
```

and

```
Traceback (most recent call last):
File "/var/lib/ambari-agent/cache/stacks/HDP/2.0.6/services/HIVE/package/scripts/hcat_client.py",
line 43, in <module>
HCatClient().execute()
File "/usr/lib/python2.6/site-packages/resource_management/libraries/script/script.py", line
122, in execute
method(env)
File "/var/lib/ambari-agent/cache/stacks/HDP/2.0.6/services/HIVE/package/scripts/hcat_client.py",
line 28, in install
self.configure(env)
File "/var/lib/ambari-agent/cache/stacks/HDP/2.0.6/services/HIVE/package/scripts/hcat_client.py",
line 31, in configure
import params
File "/var/lib/ambari-agent/cache/stacks/HDP/2.0.6/services/HIVE/package/scripts/params.py",
line 32, in <module>
hdp_stack_version = format_hdp_stack_version(hdp_stack_version)
File "/usr/lib/python2.6/site-packages/resource_management/libraries/functions/version.py",
line 43, in format_hdp_stack_version
normalized = _normalize(str(input))
File "/usr/lib/python2.6/site-packages/resource_management/libraries/functions/version.py",
line 34, in _normalize
return [int(x) for x in v_list]
ValueError: invalid literal for int() with base 10: 'GlusterFS'
```


Diffs
-----

  ambari-common/src/main/python/resource_management/libraries/functions/version.py 0f168a6

  ambari-server/src/main/resources/stacks/HDP/2.0.6/hooks/after-INSTALL/scripts/params.py
d4827f7 
  ambari-server/src/main/resources/stacks/HDP/2.0.6/hooks/before-ANY/scripts/params.py a99cdbc

  ambari-server/src/main/resources/stacks/HDP/2.0.6/hooks/before-INSTALL/scripts/params.py
4f55740 
  ambari-server/src/main/resources/stacks/HDP/2.0.6/hooks/before-START/scripts/params.py e275924

  ambari-server/src/main/resources/stacks/HDP/2.0.6/services/FLUME/package/scripts/params.py
3e00dc5 
  ambari-server/src/main/resources/stacks/HDP/2.0.6/services/HBASE/package/scripts/params.py
1757256 
  ambari-server/src/main/resources/stacks/HDP/2.0.6/services/HDFS/package/scripts/params.py
3162356 
  ambari-server/src/main/resources/stacks/HDP/2.0.6/services/HIVE/package/scripts/params.py
41c5d1a 
  ambari-server/src/main/resources/stacks/HDP/2.0.6/services/OOZIE/package/scripts/params.py
261ed55 
  ambari-server/src/main/resources/stacks/HDP/2.0.6/services/PIG/package/scripts/params.py
acee6f2 
  ambari-server/src/main/resources/stacks/HDP/2.0.6/services/SQOOP/package/scripts/params.py
4708ddb 
  ambari-server/src/main/resources/stacks/HDP/2.0.6/services/YARN/package/scripts/params.py
8e5ae9b 
  ambari-server/src/main/resources/stacks/HDP/2.0.6/services/ZOOKEEPER/package/scripts/params.py
42ba8d1 
  ambari-server/src/main/resources/stacks/HDP/2.1/services/FALCON/package/scripts/params.py
94b37ff 
  ambari-server/src/main/resources/stacks/HDP/2.1/services/STORM/package/scripts/params.py
40c0b1e 
  ambari-server/src/main/resources/stacks/HDP/2.1/services/TEZ/package/scripts/params.py 1d1a07d

  ambari-server/src/main/resources/stacks/HDP/2.2/services/KAFKA/package/scripts/params.py
5bf9036 
  ambari-server/src/main/resources/stacks/HDP/2.2/services/KNOX/package/scripts/params.py
5442329 
  ambari-server/src/main/resources/stacks/HDP/2.2/services/SLIDER/package/scripts/params.py
40f192e 
  ambari-server/src/test/python/TestVersion.py 490836e 

Diff: https://reviews.apache.org/r/27400/diff/


Testing
-------

Ran all unit tests in ambari-server,

----------------------------------------------------------------------
Total run:680
Total errors:0
Total failures:0
OK


Thanks,

Alejandro Fernandez


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message