ambari-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "John Speidel" <jspei...@hortonworks.com>
Subject Re: Review Request 27366: Adds Blueprint export handling for Knox and Zookeeper properties in HDP 2.2 stack
Date Thu, 30 Oct 2014 15:09:48 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/27366/#review59200
-----------------------------------------------------------

Ship it!


Ship It!

- John Speidel


On Oct. 30, 2014, 12:48 a.m., Robert Nettleton wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/27366/
> -----------------------------------------------------------
> 
> (Updated Oct. 30, 2014, 12:48 a.m.)
> 
> 
> Review request for Ambari, John Speidel and Nate Cole.
> 
> 
> Repository: ambari
> 
> 
> Description
> -------
> 
> This patch implements a fix for AMBARI-8021.
> 
> Some new properties introduced in the HDP 2.2 stack are not
>   being handled properly during an export of a Blueprint from
>   a running cluster.  These properties are all related to
>   either Zookeeper or Knox for several HDP 2.2 services
>   (Yarn, Kafka, Oozie, Slider, etc).
> 
> Currently, the Blueprint processor allows the hostname
>   information for these new properties to be included
>   in the exported Blueprint.  This is incorrect, since
>   hostname information is not generally useful within
>   a Blueprint.
> 
> This patch addresses the problem by adding PropertyUpdater
>   handlers for each new property.
> 
> This patch also adds unit tests and new assertions to
>   existing unit tests in order to verify this change.
> 
> 
> Diffs
> -----
> 
>   ambari-server/src/main/java/org/apache/ambari/server/controller/internal/BlueprintConfigurationProcessor.java
be379c9 
>   ambari-server/src/test/java/org/apache/ambari/server/controller/internal/BlueprintConfigurationProcessorTest.java
cf06064 
> 
> Diff: https://reviews.apache.org/r/27366/diff/
> 
> 
> Testing
> -------
> 
> 1. Ran the ambari-server unit test suite in trunk and 1.7.0, all tests are passing.
> 2. Manually verified the fix in trunk.
> 3. Manually verified the fix in 1.7.0. 
> 
> 
> Thanks,
> 
> Robert Nettleton
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message