ambari-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Aleksandr Kovalenko" <akovale...@hortonworks.com>
Subject Re: Review Request 27343: Admin View: need better username validation
Date Wed, 29 Oct 2014 19:23:47 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/27343/#review59032
-----------------------------------------------------------

Ship it!


Ship It!

- Aleksandr Kovalenko


On Жов. 29, 2014, 7:23 після полудня, Andrii Tkach wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/27343/
> -----------------------------------------------------------
> 
> (Updated Жов. 29, 2014, 7:23 після полудня)
> 
> 
> Review request for Ambari and Aleksandr Kovalenko.
> 
> 
> Bugs: AMBARI-8027
>     https://issues.apache.org/jira/browse/AMBARI-8027
> 
> 
> Repository: ambari
> 
> 
> Description
> -------
> 
> 1. Go to Manage Ambari
> 2. Try to create user
> Result: user name field accept any special characters (!*?=.|/) etc.
> 
> 
> Diffs
> -----
> 
>   ambari-admin/src/main/resources/ui/admin-web/app/scripts/controllers/users/UsersCreateCtrl.js
3fc324a 
>   ambari-admin/src/main/resources/ui/admin-web/app/scripts/controllers/users/UsersListCtrl.js
f34f4d5 
>   ambari-admin/src/main/resources/ui/admin-web/app/scripts/directives/editableList.js
5f96f90 
>   ambari-admin/src/main/resources/ui/admin-web/app/scripts/routes.js 0eff401 
>   ambari-admin/src/main/resources/ui/admin-web/app/scripts/services/Group.js cf35d4f

>   ambari-admin/src/main/resources/ui/admin-web/app/scripts/services/User.js 4ea048e 
>   ambari-admin/src/main/resources/ui/admin-web/app/views/users/list.html 76addd3 
>   ambari-server/src/main/java/org/apache/ambari/server/api/services/BaseRequest.java
d4d61f7 
>   ambari-server/src/main/java/org/apache/ambari/server/api/services/ResultPostProcessorImpl.java
bfb1e57 
>   ambari-server/src/main/java/org/apache/ambari/server/security/authorization/AmbariAuthorizationFilter.java
b184a59 
>   ambari-server/src/test/java/org/apache/ambari/server/api/services/BaseRequestTest.java
9cfd8c6 
>   ambari-server/src/test/java/org/apache/ambari/server/security/authorization/AmbariAuthorizationFilterTest.java
116b6ec 
>   ambari-web/app/router.js 25a142a 
> 
> Diff: https://reviews.apache.org/r/27343/diff/
> 
> 
> Testing
> -------
> 
> Tested manually
> 
> 
> Thanks,
> 
> Andrii Tkach
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message