ambari-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Jonathan Hurley" <jhur...@hortonworks.com>
Subject Re: Review Request 27288: Alerts: Convert Script-Style Oozie Alerts From Nagios
Date Tue, 28 Oct 2014 17:15:38 GMT


> On Oct. 28, 2014, 1 p.m., Nate Cole wrote:
> > ambari-agent/src/main/python/ambari_agent/alerts/web_alert.py, lines 57-58
> > <https://reviews.apache.org/r/27288/diff/1/?file=735471#file735471line57>
> >
> >     Is a 400/Bad Request really ok?  I would agree < 400 || 401.  403/Forbidden
may also be ok

What was I thinking!? Yes, I agree that < 400 should be OK, not <= 401. 

I don't think 403 or 407's are OK - urllib should be following redirects and whatnot until
it hits a final page, and that page better be some sort of 2xx or 3xx code. 

I will change this to "< 400"


- Jonathan


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/27288/#review58820
-----------------------------------------------------------


On Oct. 28, 2014, 12:36 p.m., Jonathan Hurley wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/27288/
> -----------------------------------------------------------
> 
> (Updated Oct. 28, 2014, 12:36 p.m.)
> 
> 
> Review request for Ambari, Alejandro Fernandez and Nate Cole.
> 
> 
> Bugs: AMBARI-8004
>     https://issues.apache.org/jira/browse/AMBARI-8004
> 
> 
> Repository: ambari
> 
> 
> Description
> -------
> 
> - Wrote Oozie SCRIPT alert to check Oozie status
> - Updated existing WEB alert messages to include the generated query string
> 
> 
> Diffs
> -----
> 
>   ambari-agent/src/main/python/ambari_agent/alerts/web_alert.py e0e36ef 
>   ambari-agent/src/test/python/ambari_agent/TestAlerts.py 74d440f 
>   ambari-server/src/main/resources/stacks/HDP/2.0.6/services/GANGLIA/alerts.json 9b115d5

>   ambari-server/src/main/resources/stacks/HDP/2.0.6/services/HBASE/alerts.json 9846848

>   ambari-server/src/main/resources/stacks/HDP/2.0.6/services/HDFS/alerts.json 9ea31f0

>   ambari-server/src/main/resources/stacks/HDP/2.0.6/services/HIVE/alerts.json 3e4865d

>   ambari-server/src/main/resources/stacks/HDP/2.0.6/services/OOZIE/alerts.json PRE-CREATION

>   ambari-server/src/main/resources/stacks/HDP/2.0.6/services/OOZIE/package/files/alert_check_oozie_server.py
PRE-CREATION 
>   ambari-server/src/main/resources/stacks/HDP/2.0.6/services/YARN/alerts.json 9793dbe

>   ambari-server/src/main/resources/stacks/HDP/2.0.6/services/YARN/package/files/alert_nodemanager_health.py
70584b0 
>   ambari-server/src/main/resources/stacks/HDP/2.0.6/services/ZOOKEEPER/alerts.json 8827294

>   ambari-server/src/main/resources/stacks/HDP/2.1/services/FALCON/alerts.json c53230f

>   ambari-server/src/main/resources/stacks/HDP/2.1/services/STORM/alerts.json df4909b

>   ambari-server/src/main/resources/stacks/HDP/2.2/services/KAFKA/alerts.json a52feac

>   ambari-server/src/main/resources/stacks/HDP/2.2/services/KNOX/alerts.json 3d2883e 
> 
> Diff: https://reviews.apache.org/r/27288/diff/
> 
> 
> Testing
> -------
> 
> Updated WEB alert tests to check for proper URL construction
> 
> [INFO] ------------------------------------------------------------------------
> [INFO] BUILD SUCCESS
> [INFO] ------------------------------------------------------------------------
> [INFO] Total time: 6.908 s
> [INFO] Finished at: 2014-10-28T12:30:33-04:00
> [INFO] Final Memory: 8M/81M
> [INFO] ------------------------------------------------------------------------
> 
> 
> Thanks,
> 
> Jonathan Hurley
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message