ambari-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Jonathan Hurley" <jhur...@hortonworks.com>
Subject Re: Review Request 27230: Alerts: Convert Script-Style HDFS, Hive, and YARN Alerts From Nagios
Date Mon, 27 Oct 2014 21:19:30 GMT


> On Oct. 27, 2014, 5:15 p.m., Alejandro Fernandez wrote:
> > ambari-server/src/main/resources/host_scripts/alert_disk_space.py, line 33
> > <https://reviews.apache.org/r/27230/diff/2/?file=734512#file734512line33>
> >
> >     host_name is not actually used in this function.

Because of the nature of how script alerts are run, it's necessary to have the ScriptAlert
class pass it in when execute is invoked. It's part of the contract.


> On Oct. 27, 2014, 5:15 p.m., Alejandro Fernandez wrote:
> > ambari-server/src/main/resources/stacks/HDP/2.0.6/services/HDFS/package/files/alert_checkpoint_time.py,
line 124
> > <https://reviews.apache.org/r/27230/diff/2/?file=734514#file734514line124>
> >
> >     In all of these tuples, (a, b) == ((a, b))

Agreed, I'll fix the double-tuple-ing.


> On Oct. 27, 2014, 5:15 p.m., Alejandro Fernandez wrote:
> > ambari-server/src/main/resources/stacks/HDP/2.0.6/services/HIVE/package/files/alert_webhcat_server.py,
line 72
> > <https://reviews.apache.org/r/27230/diff/2/?file=734517#file734517line72>
> >
> >     Can just use "if security_enabled:"

No, we cannot. 

security_enabled = False
if security_enabled:
  print 'Foo'
  
# Foo

The construct if <variable> checks for whether it has been defined, not its value.


- Jonathan


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/27230/#review58684
-----------------------------------------------------------


On Oct. 27, 2014, 5:11 p.m., Jonathan Hurley wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/27230/
> -----------------------------------------------------------
> 
> (Updated Oct. 27, 2014, 5:11 p.m.)
> 
> 
> Review request for Ambari, Nate Cole and Tom Beerbower.
> 
> 
> Bugs: AMBARI-7986
>     https://issues.apache.org/jira/browse/AMBARI-7986
> 
> 
> Repository: ambari
> 
> 
> Description
> -------
> 
> Finishing HDFS and Hive Nagios alert conversion by including the new SCRIPT alerts.
> 
> 
> Diffs
> -----
> 
>   ambari-agent/src/main/python/ambari_agent/alerts/base_alert.py 2547dd0 
>   ambari-agent/src/main/python/ambari_agent/alerts/script_alert.py 3268766 
>   ambari-server/src/main/resources/host_scripts/alert_disk_space.py 3c7a842 
>   ambari-server/src/main/resources/stacks/HDP/2.0.6/services/HDFS/alerts.json c506c32

>   ambari-server/src/main/resources/stacks/HDP/2.0.6/services/HDFS/package/files/alert_checkpoint_time.py
PRE-CREATION 
>   ambari-server/src/main/resources/stacks/HDP/2.0.6/services/HIVE/alerts.json c97775d

>   ambari-server/src/main/resources/stacks/HDP/2.0.6/services/HIVE/package/files/alert_hive_thrift_port.py
PRE-CREATION 
>   ambari-server/src/main/resources/stacks/HDP/2.0.6/services/HIVE/package/files/alert_webhcat_server.py
PRE-CREATION 
>   ambari-server/src/main/resources/stacks/HDP/2.0.6/services/YARN/alerts.json d4af868

>   ambari-server/src/main/resources/stacks/HDP/2.0.6/services/YARN/package/files/alert_nodemanager_health.py
PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/27230/diff/
> 
> 
> Testing
> -------
> 
> Each script was tested against an installed cluster for each possible path:
> 1) Invalid URLs
> 2) URLs that return unexpected data
> 3) URLs that return correct data
> 
> 
> Thanks,
> 
> Jonathan Hurley
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message