ambari-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Tom Beerbower" <tbeerbo...@hortonworks.com>
Subject Re: Review Request 27194: Views: on deploy, validate view.xml
Date Mon, 27 Oct 2014 00:42:01 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/27194/
-----------------------------------------------------------

(Updated Oct. 27, 2014, 12:42 a.m.)


Review request for Ambari, Jonathan Hurley and Nate Cole.


Changes
-------

patch updated


Bugs: AMBARI-7964
    https://issues.apache.org/jira/browse/AMBARI-7964


Repository: ambari


Description
-------

On view deploy: perform validation of view.xml in view package and if the view.xml does not
validate, provide a specific error to the log.
Validation can be an optional operation that can be enabled/disabled in the ambari server
(maybe just a prop in ambari.properties view.validation.enabled=true/false)?


Diffs (updated)
-----

  ambari-server/src/main/java/org/apache/ambari/server/configuration/Configuration.java 535e569

  ambari-server/src/main/java/org/apache/ambari/server/view/ViewArchiveUtility.java f5f2732

  ambari-server/src/main/java/org/apache/ambari/server/view/ViewRegistry.java c4da8b4 
  ambari-server/src/test/java/org/apache/ambari/server/configuration/ConfigurationTest.java
12b5333 
  ambari-server/src/test/java/org/apache/ambari/server/view/ViewArchiveUtilityTest.java PRE-CREATION

  ambari-server/src/test/java/org/apache/ambari/server/view/ViewExtractorTest.java 1b71c37

  ambari-server/src/test/java/org/apache/ambari/server/view/ViewRegistryTest.java 7c0cade

  ambari-server/src/test/resources/test_view.xml PRE-CREATION 

Diff: https://reviews.apache.org/r/27194/diff/


Testing
-------

Manual testing.  New unit tests added.  All existing pass ...


Results :

Tests run: 2202, Failures: 0, Errors: 0, Skipped: 14

...


[INFO] ------------------------------------------------------------------------
[INFO] BUILD SUCCESS
[INFO] ------------------------------------------------------------------------
[INFO] Total time: 36:45.663s
[INFO] Finished at: Sat Oct 25 08:06:24 EDT 2014
[INFO] Final Memory: 41M/344M
[INFO] ------------------------------------------------------------------------


Thanks,

Tom Beerbower


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message