ambari-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Alejandro Fernandez" <afernan...@hortonworks.com>
Subject Re: Review Request 27158: Dialog overlays do not receive keyboard focus
Date Sat, 25 Oct 2014 00:45:14 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/27158/#review58460
-----------------------------------------------------------

Ship it!


Ship It!

- Alejandro Fernandez


On Oct. 24, 2014, 8:16 p.m., Anthony Penniston wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/27158/
> -----------------------------------------------------------
> 
> (Updated Oct. 24, 2014, 8:16 p.m.)
> 
> 
> Review request for Ambari.
> 
> 
> Bugs: AMBARI-7728
>     https://issues.apache.org/jira/browse/AMBARI-7728
> 
> 
> Repository: ambari
> 
> 
> Description
> -------
> 
> Message boxes do not receive focus. This was observed in at least two places on the Configs
screen, where typing on they keyboard still sent characters to the background page rather
than the overlayed pop-up.
> 
> 
> Diffs
> -----
> 
>   ambari-web/app/assets/test/tests.js cd78e01 
>   ambari-web/app/views/common/modal_popup.js 223a77a 
>   ambari-web/test/views/common/modal_popup_test.js PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/27158/diff/
> 
> 
> Testing
> -------
> 
> on config screen, activated modal dialog by clicking 'Add custom property', ensured that
first input textbox was focused by default.
> 
> 
> Thanks,
> 
> Anthony Penniston
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message