ambari-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Jaimin Jetly" <jai...@hortonworks.com>
Subject Re: Review Request 27178: Remove experimental flag for the features that are already part of ambari
Date Fri, 24 Oct 2014 23:45:41 GMT


> On Oct. 24, 2014, 11:18 p.m., Yusaku Sako wrote:
> > ambari-web/app/models/quick_links.js, line 285
> > <https://reviews.apache.org/r/27178/diff/1/?file=733057#file733057line285>
> >
> >     Is this OK?  I'm worried that this is being referenced like an array and removing
would shift everything.

As far as id for every object is unique, App.QuickLinks.find() will return the bucket of all
quicklinks. The fixture for ember-data class is not supposed to be used directly as an array
in the application and is correctly not being used anywhere in ambari for any model.  

I verified that quick links work for the services defined before HUE and after HUE are working
with the patch.

I also noted that these links are being explicitly mapped to the service model in the service_metrics_mapper.js
which is not intuitive. The code should be refactred to map a quick link to the service more
generically.


> On Oct. 24, 2014, 11:18 p.m., Yusaku Sako wrote:
> > ambari-web/app/mappers/service_metrics_mapper.js, line 387
> > <https://reviews.apache.org/r/27178/diff/1/?file=733052#file733052line387>
> >
> >     I'm not really sure how things would be affected.

see the comment for the below question.


- Jaimin


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/27178/#review58434
-----------------------------------------------------------


On Oct. 24, 2014, 10:59 p.m., Jaimin Jetly wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/27178/
> -----------------------------------------------------------
> 
> (Updated Oct. 24, 2014, 10:59 p.m.)
> 
> 
> Review request for Ambari, Srimanth Gunturi and Yusaku Sako.
> 
> 
> Bugs: AMBARI-7963
>     https://issues.apache.org/jira/browse/AMBARI-7963
> 
> 
> Repository: ambari
> 
> 
> Description
> -------
> 
> The only two flags that should remain from previous releases of ambari should be:
> 1. stackUpgrade
> 2. autoRollbackHA
> 
> 
> Diffs
> -----
> 
>   ambari-web/app/assets/data/clusters/cluster.json 19f916d 
>   ambari-web/app/assets/data/clusters/tags_and_groups.json 4c88d8d 
>   ambari-web/app/assets/data/configurations/cluster_level_configs.json e1b2851 
>   ambari-web/app/assets/data/dashboard/services.json b1dbc8e 
>   ambari-web/app/assets/data/hosts/hosts.json 4d67973 
>   ambari-web/app/assets/data/services/host_component_actual_configs.json 8956fee 
>   ambari-web/app/assets/data/wizard/stack/hdp/version1.3.0/HUE.json e208129 
>   ambari-web/app/assets/data/wizard/stack/hdp/version1.3.0/global.json 04379e1 
>   ambari-web/app/assets/data/wizard/stack/hdp/version131/HUE.json 895aa35 
>   ambari-web/app/assets/data/wizard/stack/hdp/version131/global.json 37b2665 
>   ambari-web/app/assets/data/wizard/stack/hdp/version2.0.1/HUE.json e208129 
>   ambari-web/app/assets/data/wizard/stack/hdp/version2.0.1/global.json 04379e1 
>   ambari-web/app/assets/data/wizard/stack/stacks.json 4f51def 
>   ambari-web/app/assets/test/tests.js cd78e01 
>   ambari-web/app/config.js 563e547 
>   ambari-web/app/controllers.js c4a1001 
>   ambari-web/app/controllers/global/cluster_controller.js e6e4b03 
>   ambari-web/app/controllers/global/update_controller.js 125f592 
>   ambari-web/app/controllers/main/admin/repositories.js 65e3f96 
>   ambari-web/app/controllers/main/host/details.js 647fa44 
>   ambari-web/app/controllers/main/service.js 0566612 
>   ambari-web/app/controllers/main/service/info/configs.js afd263f 
>   ambari-web/app/controllers/wizard.js 01f3ea2 
>   ambari-web/app/controllers/wizard/step5_controller.js 6fb9ab1 
>   ambari-web/app/controllers/wizard/step6_controller.js 1142c8a 
>   ambari-web/app/controllers/wizard/step7_controller.js 645d435 
>   ambari-web/app/controllers/wizard/step8_controller.js de1929d 
>   ambari-web/app/data/BIGTOP/site_properties.js da61b78 
>   ambari-web/app/data/HDP2/site_properties.js c298924 
>   ambari-web/app/data/site_properties.js d577819 
>   ambari-web/app/mappers/service_metrics_mapper.js 0464067 
>   ambari-web/app/mappers/stack_service_mapper.js 6a13bd3 
>   ambari-web/app/messages.js e3e265c 
>   ambari-web/app/mixins/common/serverValidator.js ca1367f 
>   ambari-web/app/models.js c127515 
>   ambari-web/app/models/quick_links.js 2da22e7 
>   ambari-web/app/models/service_config.js 2d15301 
>   ambari-web/app/models/stack_service.js 4c86b20 
>   ambari-web/app/models/stack_service_component.js d88f02a 
>   ambari-web/app/models/user.js f51d07c 
>   ambari-web/app/routes/add_host_routes.js ff281a9 
>   ambari-web/app/routes/add_service_routes.js 4e4b83e 
>   ambari-web/app/routes/installer.js 9fc3d39 
>   ambari-web/app/routes/main.js 25f1714 
>   ambari-web/app/templates/common/configs/capacity_scheduler.hbs 6ccd55f 
>   ambari-web/app/templates/common/configs/service_config.hbs 14bcd30 
>   ambari-web/app/templates/common/configs/service_config_category.hbs 0aaf35f 
>   ambari-web/app/templates/common/host_progress_popup.hbs a80cd65 
>   ambari-web/app/templates/main/host/add.hbs 8d35a9a 
>   ambari-web/app/templates/main/host/details.hbs ecd4a63 
>   ambari-web/app/templates/main/service/all_services_actions.hbs e7dd68e 
>   ambari-web/app/templates/main/service/info/configs.hbs b4ec65c 
>   ambari-web/app/templates/main/service/info/summary.hbs 080a3f7 
>   ambari-web/app/templates/wizard/step1.hbs b1e323f 
>   ambari-web/app/templates/wizard/step2.hbs 553c8e3 
>   ambari-web/app/utils/config.js 75eda91 
>   ambari-web/app/utils/host_progress_popup.js b9e7b6a 
>   ambari-web/app/views.js 2766539 
>   ambari-web/app/views/common/configs/services_config.js 24086f7 
>   ambari-web/app/views/common/quick_view_link_view.js ce859e6 
>   ambari-web/app/views/main/admin.js 89c0d6d 
>   ambari-web/app/views/main/dashboard.js 9705203 
>   ambari-web/app/views/main/dashboard/widgets/hbase_links.js ba93812 
>   ambari-web/app/views/main/host/details/host_component_view.js 790e4ba 
>   ambari-web/app/views/main/host/menu.js 5490eb1 
>   ambari-web/app/views/main/host/summary.js 3ccf01c 
>   ambari-web/app/views/main/menu.js 89e9ac8 
>   ambari-web/app/views/main/service/item.js e52b2d8 
>   ambari-web/app/views/main/service/services/hbase.js e70310c 
>   ambari-web/app/views/wizard/controls_view.js ae9f721 
>   ambari-web/test/controllers/global/update_controller_test.js df4420e 
>   ambari-web/test/controllers/main/host/details_test.js 084fc8d 
>   ambari-web/test/controllers/main/service/info/config_test.js a7dcb0b 
>   ambari-web/test/controllers/main/service_test.js 808bbe7 
>   ambari-web/test/controllers/wizard/step6_test.js e1fadaa 
>   ambari-web/test/controllers/wizard/step7_test.js d405426 
>   ambari-web/test/controllers/wizard/step9_test.js 4ac8e1f 
>   ambari-web/test/models/stack_service_component_test.js c6ab457 
>   ambari-web/test/models/user_test.js d844472 
>   ambari-web/test/views/common/configs/services_config_test.js 2014dea 
> 
> Diff: https://reviews.apache.org/r/27178/diff/
> 
> 
> Testing
> -------
> 
> tested e2e
> 
> 
> Thanks,
> 
> Jaimin Jetly
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message