ambari-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Robert Nettleton" <rnettle...@hortonworks.com>
Subject Re: Review Request 26952: ShellCommandUtil.Results class should be public, not package private
Date Thu, 23 Oct 2014 15:51:30 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/26952/#review57995
-----------------------------------------------------------

Ship it!


This change looks fine to me.  In the future, we may want to consider moving this class to
the top-level, since it looks like it is basically part of a public-facing API.

- Robert Nettleton


On Oct. 22, 2014, 7:51 p.m., Robert Levas wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/26952/
> -----------------------------------------------------------
> 
> (Updated Oct. 22, 2014, 7:51 p.m.)
> 
> 
> Review request for Ambari and John Speidel.
> 
> 
> Bugs: AMBARI-7870
>     https://issues.apache.org/jira/browse/AMBARI-7870
> 
> 
> Repository: ambari
> 
> 
> Description
> -------
> 
> ShellCommandUtil.Results class should be _public_, _not package_ private. Because it
is _package private_, any ShellCommandUtil public methods returning a ShellCommandUtil.Results
is basically unusable outside of the org.apache.ambari.server.utils package.
> 
> Solution:  Make ShellCommandUtil.Results and its methods explicitly _public_
> 
> 
> Diffs
> -----
> 
>   ambari-server/src/main/java/org/apache/ambari/server/utils/ShellCommandUtil.java ee83aa0

>   ambari-server/src/test/java/org/apache/ambari/server/utils/TestShellCommandUtil.java
27a033c 
> 
> Diff: https://reviews.apache.org/r/26952/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Robert Levas
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message