ambari-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Oleg Nechiporenko" <onechipore...@apache.org>
Subject Review Request 27069: Admin View: description is being variable replaced
Date Thu, 23 Oct 2014 09:27:48 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/27069/
-----------------------------------------------------------

Review request for Ambari, Aleksandr Kovalenko and Andrii Tkach.


Bugs: ambari-7916
    https://issues.apache.org/jira/browse/ambari-7916


Repository: ambari


Description
-------

On instance create, when loading a instance parameter description that includes text that
looks a variable (for example {username}), the username is being replaced.
This can be seen with the Slider View and the slider.user parameter description.
Note: I only see this during create view instance. Edit view instance parameters does not
seem to do the replace of the description string.


Diffs
-----

  ambari-admin/src/main/resources/ui/admin-web/app/scripts/controllers/ambariViews/CreateViewInstanceCtrl.js
68421fa 
  ambari-admin/src/main/resources/ui/admin-web/test/unit/controllers/ambariViews/CreateViewInstanceCtrl_test.js
4deaf52 

Diff: https://reviews.apache.org/r/27069/diff/


Testing
-------


Thanks,

Oleg Nechiporenko


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message