ambari-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Nate Cole" <nc...@hortonworks.com>
Subject Re: Review Request 26989: Alerts: Convert HDFS Nagios Alerts Into Ambari
Date Tue, 21 Oct 2014 20:12:27 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/26989/#review57645
-----------------------------------------------------------

Ship it!



ambari-server/src/main/resources/stacks/HDP/2.0.6/services/HDFS/alerts.json
<https://reviews.apache.org/r/26989/#comment98448>

    Sweet!


- Nate Cole


On Oct. 21, 2014, 3:30 p.m., Jonathan Hurley wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/26989/
> -----------------------------------------------------------
> 
> (Updated Oct. 21, 2014, 3:30 p.m.)
> 
> 
> Review request for Ambari, Nate Cole and Tom Beerbower.
> 
> 
> Bugs: AMBARI-7889
>     https://issues.apache.org/jira/browse/AMBARI-7889
> 
> 
> Repository: ambari
> 
> 
> Description
> -------
> 
> Convert the existing HDFS alerts defined in Nagios' hadoop-services.cfg file into the
new alerts.json.
> 
> This required some of the following updates to the Alerts infrastructure:
> - A new type of alert called "WEB" which makes an http(s) request and returns a return
code.
> - The ability for the URI of the METRIC and WEB alerts to be a structure that specifies
both plaintext and SSL URLs (or only 1 if there is only 1 property)
> 
> Note that the change in alert format forces us to wipe the alerts out of the database.
This is probably something we'll need to revisit once we ship the first release of alerts.
> 
> 
> Diffs
> -----
> 
>   ambari-agent/src/main/python/ambari_agent/AlertSchedulerHandler.py 5863b23 
>   ambari-agent/src/main/python/ambari_agent/alerts/base_alert.py a3eb404 
>   ambari-agent/src/main/python/ambari_agent/alerts/metric_alert.py 5e4ea9e 
>   ambari-agent/src/main/python/ambari_agent/alerts/web_alert.py PRE-CREATION 
>   ambari-agent/src/test/python/ambari_agent/TestAlerts.py 78f3e10 
>   ambari-agent/src/test/python/ambari_agent/TestHostInfo.py 71129c7 
>   ambari-server/src/main/java/org/apache/ambari/server/state/alert/AlertDefinitionFactory.java
9c72b6a 
>   ambari-server/src/main/java/org/apache/ambari/server/state/alert/AlertUri.java PRE-CREATION

>   ambari-server/src/main/java/org/apache/ambari/server/state/alert/MetricSource.java
15351d9 
>   ambari-server/src/main/java/org/apache/ambari/server/state/alert/SourceType.java 18c13bd

>   ambari-server/src/main/java/org/apache/ambari/server/state/alert/WebSource.java PRE-CREATION

>   ambari-server/src/main/resources/stacks/HDP/2.0.6/services/HDFS/alerts.json d81170a

>   ambari-server/src/test/resources/stacks/HDP/2.0.5/services/HDFS/alerts.json 0077bad

> 
> Diff: https://reviews.apache.org/r/26989/diff/
> 
> 
> Testing
> -------
> 
> New cluster installation, verified new alerts are distributed and run. New tests written
to cover changes to the python alerts.
> 
> [INFO] ------------------------------------------------------------------------
> [INFO] BUILD SUCCESS
> [INFO] ------------------------------------------------------------------------
> [INFO] Total time: 9.378 s
> [INFO] Finished at: 2014-10-21T15:25:20-04:00
> [INFO] Final Memory: 8M/81M
> 
> 
> Thanks,
> 
> Jonathan Hurley
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message