ambari-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "John Speidel" <jspei...@hortonworks.com>
Subject Re: Review Request 26981: Added export handling for new Hive/Zookeeper config property in HDP 2.2
Date Tue, 21 Oct 2014 19:33:26 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/26981/#review57642
-----------------------------------------------------------

Ship it!


Ship It!

- John Speidel


On Oct. 21, 2014, 4:15 p.m., Robert Nettleton wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/26981/
> -----------------------------------------------------------
> 
> (Updated Oct. 21, 2014, 4:15 p.m.)
> 
> 
> Review request for Ambari, John Speidel and Nate Cole.
> 
> 
> Repository: ambari
> 
> 
> Description
> -------
> 
> This patch implements a fix for Ambari Bug AMBARI-7869.
> 
> The following hive-site.xml property:
> 
> hive.cluster.delegation.token.store.zookeeper.connectString
> 
> has recently been added to the HDP 2.2 stack definition.
> 
> Currently, if an export is attempted on an HDP 2.2 cluster that includes
>   Hive, the export of this property will include hostname information.
> 
> This patch addresses this problem by registering the relevant
>   PropertyUpdater implementation for this property, to ensure
>   that the export process removes hostname information, and instead
>   refers to the host group that includes the Zookeeper server.
> 
> This patch also adds a new assertion to an existing unit test
>   to verify this change.
> 
> 
> Diffs
> -----
> 
>   ambari-server/src/main/java/org/apache/ambari/server/controller/internal/BlueprintConfigurationProcessor.java
0b58c8d 
>   ambari-server/src/test/java/org/apache/ambari/server/controller/internal/BlueprintConfigurationProcessorTest.java
a57bacb 
> 
> Diff: https://reviews.apache.org/r/26981/diff/
> 
> 
> Testing
> -------
> 
> 1. Ran unit tests with change applied (in trunk and 1.7), and all unit tests are passing.
> 2. Manually verified the fix against trunk.
> 3. Manually verified the fix against 1.7.0. 
> 
> 
> Thanks,
> 
> Robert Nettleton
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message