ambari-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Dmytro Sen" <d...@hortonworks.com>
Subject Re: Review Request 26976: HDP-2.2 stack should not hard code rpm version to 2.2.0.0 in cluster-env.xml
Date Tue, 21 Oct 2014 17:54:39 GMT


> On Окт. 21, 2014, 5:45 п.п., Alejandro Fernandez wrote:
> > ambari-server/src/main/resources/stacks/HDP/2.1/services/TEZ/package/scripts/params.py,
line 27
> > <https://reviews.apache.org/r/26976/diff/3/?file=727442#file727442line27>
> >
> >     I forgot one more thing, Tez is currently the only service actually consuming
the rpm_version variable in params.py, so we need to keep it there, at least until I can remove
it.
> >     I'm currently working on transitioning WebHCat, and then Oozie and MR.
> 
> Alejandro Fernandez wrote:
>     This is the last issue. I can then +1.

uploaded updated patch


- Dmytro


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/26976/#review57616
-----------------------------------------------------------


On Окт. 21, 2014, 5:53 п.п., Dmytro Sen wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/26976/
> -----------------------------------------------------------
> 
> (Updated Окт. 21, 2014, 5:53 п.п.)
> 
> 
> Review request for Ambari, Dmitro Lisnichenko and Sumit Mohanty.
> 
> 
> Bugs: AMBARI-7884
>     https://issues.apache.org/jira/browse/AMBARI-7884
> 
> 
> Repository: ambari
> 
> 
> Description
> -------
> 
> File - src/main/resources/stacks/HDP/2.2/configuration/cluster-env.xml specifies the
rpm version as 2.2.0.0.
> The actual value of the rpm version should be read from the json file that specifies
the latest repo URL. Ensure that it is being done and when HDP 2.2.0.1 or later is released
the latest HDP-2.2. is deployed when HDP-2.2. is selected by user.The actual value of the
rpm version should be read from the json file that specifies the latest repo URL. Ensure that
it is being done and when HDP 2.2.0.1 or later is released the latest HDP-2.2. is deployed
when HDP-2.2. is selected by user.
> 
> 
> Diffs
> -----
> 
>   ambari-server/src/main/resources/stacks/HDP/1.3.2/hooks/before-ANY/scripts/params.py
84d19dc 
>   ambari-server/src/main/resources/stacks/HDP/2.0.6/hooks/after-INSTALL/scripts/params.py
bd26397 
>   ambari-server/src/main/resources/stacks/HDP/2.0.6/hooks/after-INSTALL/scripts/shared_initialization.py
ee6635f 
>   ambari-server/src/main/resources/stacks/HDP/2.0.6/hooks/before-ANY/scripts/params.py
17e3732 
>   ambari-server/src/main/resources/stacks/HDP/2.0.6/hooks/before-INSTALL/scripts/params.py
a8ad47e 
>   ambari-server/src/main/resources/stacks/HDP/2.0.6/hooks/before-INSTALL/scripts/shared_initialization.py
1070a22 
>   ambari-server/src/main/resources/stacks/HDP/2.0.6/hooks/before-START/scripts/params.py
dd20c44 
>   ambari-server/src/main/resources/stacks/HDP/2.0.6/services/FLUME/package/scripts/params.py
55a6d29 
>   ambari-server/src/main/resources/stacks/HDP/2.0.6/services/HBASE/package/scripts/params.py
5adae42 
>   ambari-server/src/main/resources/stacks/HDP/2.0.6/services/HDFS/package/scripts/params.py
6b16205 
>   ambari-server/src/main/resources/stacks/HDP/2.0.6/services/HIVE/package/scripts/params.py
7c86070 
>   ambari-server/src/main/resources/stacks/HDP/2.0.6/services/OOZIE/package/scripts/params.py
3dbe1fe 
>   ambari-server/src/main/resources/stacks/HDP/2.0.6/services/PIG/package/scripts/params.py
f28e541 
>   ambari-server/src/main/resources/stacks/HDP/2.0.6/services/SQOOP/package/scripts/params.py
4325ffc 
>   ambari-server/src/main/resources/stacks/HDP/2.0.6/services/YARN/package/scripts/params.py
f88569c 
>   ambari-server/src/main/resources/stacks/HDP/2.0.6/services/ZOOKEEPER/package/scripts/params.py
4ececf3 
>   ambari-server/src/main/resources/stacks/HDP/2.1/services/FALCON/package/scripts/params.py
a144cab 
>   ambari-server/src/main/resources/stacks/HDP/2.1/services/STORM/package/scripts/params.py
89c389f 
>   ambari-server/src/main/resources/stacks/HDP/2.1/services/TEZ/package/scripts/params.py
71989c3 
>   ambari-server/src/main/resources/stacks/HDP/2.2/services/FALCON/metainfo.xml f484378

>   ambari-server/src/main/resources/stacks/HDP/2.2/services/FLUME/metainfo.xml c21c478

>   ambari-server/src/main/resources/stacks/HDP/2.2/services/HBASE/metainfo.xml 78d7f97

>   ambari-server/src/main/resources/stacks/HDP/2.2/services/HDFS/metainfo.xml f50b6e2

>   ambari-server/src/main/resources/stacks/HDP/2.2/services/HIVE/metainfo.xml 32a3e75

>   ambari-server/src/main/resources/stacks/HDP/2.2/services/KAFKA/metainfo.xml 3eb0768

>   ambari-server/src/main/resources/stacks/HDP/2.2/services/KAFKA/package/scripts/params.py
502b6d9 
>   ambari-server/src/main/resources/stacks/HDP/2.2/services/KNOX/metainfo.xml 993b456

>   ambari-server/src/main/resources/stacks/HDP/2.2/services/KNOX/package/scripts/params.py
5c5abe4 
>   ambari-server/src/main/resources/stacks/HDP/2.2/services/OOZIE/metainfo.xml e14a9a4

>   ambari-server/src/main/resources/stacks/HDP/2.2/services/PIG/metainfo.xml dff2ae7 
>   ambari-server/src/main/resources/stacks/HDP/2.2/services/SLIDER/metainfo.xml d3433e9

>   ambari-server/src/main/resources/stacks/HDP/2.2/services/SLIDER/package/scripts/params.py
33371a8 
>   ambari-server/src/main/resources/stacks/HDP/2.2/services/SQOOP/metainfo.xml 3e90798

>   ambari-server/src/main/resources/stacks/HDP/2.2/services/STORM/metainfo.xml 9f17256

>   ambari-server/src/main/resources/stacks/HDP/2.2/services/TEZ/metainfo.xml f054f04 
>   ambari-server/src/main/resources/stacks/HDP/2.2/services/YARN/metainfo.xml 8049fb8

>   ambari-server/src/main/resources/stacks/HDP/2.2/services/ZOOKEEPER/metainfo.xml 4340b11

>   ambari-server/src/test/python/stacks/2.0.6/HDFS/test_datanode.py 3ee7c98 
>   ambari-server/src/test/python/stacks/2.1/configs/default-storm-start.json 18ded8c 
>   ambari-server/src/test/python/stacks/2.1/configs/secured-storm-start.json 8183ba0 
>   ambari-server/src/test/python/stacks/2.2/SLIDER/test_slider_client.py 073a4ed 
>   ambari-server/src/test/python/stacks/2.2/configs/default.json ea474e8 
> 
> Diff: https://reviews.apache.org/r/26976/diff/
> 
> 
> Testing
> -------
> 
> Ran 234 tests in 2.585s
> 
> OK
> ----------------------------------------------------------------------
> Total run:667
> Total errors:0
> Total failures:0
> OK
> 
> 
> Thanks,
> 
> Dmytro Sen
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message