ambari-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Alejandro Fernandez" <afernan...@hortonworks.com>
Subject Re: Review Request 26934: Ambari should support for Pig-on-Tez
Date Tue, 21 Oct 2014 02:30:22 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/26934/#review57531
-----------------------------------------------------------



ambari-server/src/main/resources/stacks/HDP/2.0.6/services/PIG/package/scripts/service_check.py
<https://reviews.apache.org/r/26934/#comment98264>

    This is not a big issue, but stylistically, we should follow the PEP 8 style guide so
that params are indented right below the "(", and the "=" is directly after the parameter
name.


- Alejandro Fernandez


On Oct. 20, 2014, 6:37 p.m., Dmitro Lisnichenko wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/26934/
> -----------------------------------------------------------
> 
> (Updated Oct. 20, 2014, 6:37 p.m.)
> 
> 
> Review request for Ambari, Dmytro Sen, Myroslav Papirkovskyy, and Vitalyi Brodetskyi.
> 
> 
> Bugs: AMBARI-7863
>     https://issues.apache.org/jira/browse/AMBARI-7863
> 
> 
> Repository: ambari
> 
> 
> Description
> -------
> 
> Pig on Tez will be in Champlain and we need Ambari support it
> 
> 
> Diffs
> -----
> 
>   ambari-server/src/main/resources/stacks/HDP/2.0.6/services/HDFS/package/scripts/params.py
1308aa2 
>   ambari-server/src/main/resources/stacks/HDP/2.0.6/services/HDFS/package/scripts/utils.py
5e1221a 
>   ambari-server/src/main/resources/stacks/HDP/2.0.6/services/PIG/package/scripts/params.py
785b89d 
>   ambari-server/src/main/resources/stacks/HDP/2.0.6/services/PIG/package/scripts/service_check.py
7619bd6 
>   ambari-server/src/main/resources/stacks/HDP/2.2/services/PIG/metainfo.xml bd0b5ce 
>   ambari-server/src/test/python/stacks/2.0.6/PIG/test_pig_client.py 2874614 
> 
> Diff: https://reviews.apache.org/r/26934/diff/
> 
> 
> Testing
> -------
> 
> [INFO] Reactor Summary:
> [INFO] 
> [INFO] Ambari Main ....................................... SUCCESS [2.398s]
> [INFO] Apache Ambari Project POM ......................... SUCCESS [0.173s]
> [INFO] Ambari Web ........................................ SUCCESS [44.231s]
> [INFO] Ambari Views ...................................... SUCCESS [2.718s]
> [INFO] Ambari Admin View ................................. SUCCESS [59.651s]
> [INFO] Ambari Server ..................................... SUCCESS [43.740s]
> [INFO] Ambari Agent ...................................... SUCCESS [5.398s]
> [INFO] Ambari Client ..................................... SUCCESS [0.002s]
> [INFO] Ambari Python Client .............................. SUCCESS [1.114s]
> [INFO] Ambari Groovy Client .............................. SUCCESS [3.191s]
> [INFO] Ambari Shell ...................................... SUCCESS [0.003s]
> [INFO] Ambari Python Shell ............................... SUCCESS [0.003s]
> [INFO] Ambari Groovy Shell ............................... SUCCESS [3.005s]
> [INFO] ------------------------------------------------------------------------
> [INFO] BUILD SUCCESS
> [INFO] ------------------------------------------------------------------------
> 
> 
> Thanks,
> 
> Dmitro Lisnichenko
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message