ambari-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Oleg Nechiporenko" <onechipore...@apache.org>
Subject Re: Review Request 26942: Slider View: Create Slider App dialog should appear at top of the page
Date Mon, 20 Oct 2014 16:27:27 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/26942/#review57351
-----------------------------------------------------------

Ship it!


Ship It!

- Oleg Nechiporenko


On Oct. 20, 2014, 4:26 p.m., Aleksandr Kovalenko wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/26942/
> -----------------------------------------------------------
> 
> (Updated Oct. 20, 2014, 4:26 p.m.)
> 
> 
> Review request for Ambari, Andrii Tkach and Oleg Nechiporenko.
> 
> 
> Bugs: ABMARI-7868
>     https://issues.apache.org/jira/browse/ABMARI-7868
> 
> 
> Repository: ambari
> 
> 
> Description
> -------
> 
> Sometimes, due to the graphs or metrics summary (HBase app), the IFrame size grows too
big for the screen. When this happens (small scrollbar with large white area below), and Create
App button is clicked, the window appears in the middle of the scroll-area - making it look
like Create App button didnt work. The dialog actually shows up, but is in the middle of the
page below in the scroll. 
> 
> We should try to put the dialog at the top of the page (vertical-alignment: top), so
that no matter what the vertical length of iframe, the dialog always shows up in the top area.
> 
> 
> Diffs
> -----
> 
>   ambari-web/app/views/main/views/details.js 92dd358 
> 
> Diff: https://reviews.apache.org/r/26942/diff/
> 
> 
> Testing
> -------
> 
> tested on real cluster
> 
> 
> Thanks,
> 
> Aleksandr Kovalenko
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message