ambari-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Dmytro Sen" <d...@hortonworks.com>
Subject Re: Review Request 22972: Repoinfo.xml should use family tag rather than type tag
Date Wed, 15 Oct 2014 09:52:14 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/22972/#review56680
-----------------------------------------------------------

Ship it!


Ship It!

- Dmytro Sen


On Окт. 14, 2014, 3:18 п.п., Andrew Onischuk wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/22972/
> -----------------------------------------------------------
> 
> (Updated Окт. 14, 2014, 3:18 п.п.)
> 
> 
> Review request for Ambari and Dmytro Sen.
> 
> 
> Bugs: AMBARI-6270
>     https://issues.apache.org/jira/browse/AMBARI-6270
> 
> 
> Repository: ambari
> 
> 
> Description
> -------
> 
> That is a bit confusing we should change that, since we changed the way it
> works
> 
>     
>     
>     
>     <os type="redhat6">
>     
> 
> should be
> 
>     
>     
>     
>     <os family="redhat6">
>     
> 
> 
> Diffs
> -----
> 
>   ambari-common/src/main/python/ambari_commons/os_check.py dfbd9e2 
>   ambari-common/src/main/python/ambari_commons/resources/os_family.json PRE-CREATION

>   ambari-server/conf/unix/ambari.properties d37174f 
>   ambari-server/src/main/java/org/apache/ambari/server/api/services/AmbariMetaInfo.java
02c103c 
>   ambari-server/src/main/java/org/apache/ambari/server/bootstrap/BSRunner.java 7795c99

>   ambari-server/src/main/java/org/apache/ambari/server/bootstrap/BootStrapImpl.java 1f68f1f

>   ambari-server/src/main/java/org/apache/ambari/server/configuration/Configuration.java
315e1a6 
>   ambari-server/src/main/java/org/apache/ambari/server/controller/AmbariCustomCommandExecutionHelper.java
92935e4 
>   ambari-server/src/main/java/org/apache/ambari/server/controller/AmbariServer.java d428b80

>   ambari-server/src/main/java/org/apache/ambari/server/controller/ControllerModule.java
535a75e 
>   ambari-server/src/main/java/org/apache/ambari/server/state/stack/LatestRepoCallable.java
efb2d0a 
>   ambari-server/src/main/java/org/apache/ambari/server/state/stack/OsFamily.java 83bf46b

>   ambari-server/src/main/java/org/apache/ambari/server/state/stack/RepositoryXml.java
bd98a9f 
>   ambari-server/src/main/java/org/apache/ambari/server/upgrade/StackUpgradeUtil.java
f443146 
>   ambari-server/src/main/python/ambari-server.py 4988708 
>   ambari-server/src/main/python/bootstrap.py 5ebfbf2 
>   ambari-server/src/main/python/os_check_type.py 7fefed3 
>   ambari-server/src/main/resources/stacks/BIGTOP/0.8/repos/repoinfo.xml d7c534f 
>   ambari-server/src/main/resources/stacks/HDP/1.3.2/repos/repoinfo.xml 0486765 
>   ambari-server/src/main/resources/stacks/HDP/1.3.3/repos/repoinfo.xml e3f7494 
>   ambari-server/src/main/resources/stacks/HDP/1.3/repos/repoinfo.xml 904fce1 
>   ambari-server/src/main/resources/stacks/HDP/2.0.6.GlusterFS/repos/repoinfo.xml f86b40a

>   ambari-server/src/main/resources/stacks/HDP/2.0.6/repos/repoinfo.xml b7424e0 
>   ambari-server/src/main/resources/stacks/HDP/2.0/repos/repoinfo.xml 4c5ce1d 
>   ambari-server/src/main/resources/stacks/HDP/2.1.GlusterFS/repos/repoinfo.xml a57e03a

>   ambari-server/src/main/resources/stacks/HDP/2.1/repos/repoinfo.xml f754093 
>   ambari-server/src/main/resources/stacks/HDP/2.2/repos/repoinfo.xml a9f99bc 
>   ambari-server/src/test/java/org/apache/ambari/server/agent/AgentResourceTest.java b953467

>   ambari-server/src/test/java/org/apache/ambari/server/api/services/UpdatePersistenceManagerTest.java
b60680c 
>   ambari-server/src/test/java/org/apache/ambari/server/bootstrap/BootStrapTest.java 34ccf6e

>   ambari-server/src/test/java/org/apache/ambari/server/controller/AmbariManagementControllerTest.java
c9c8258 
>   ambari-server/src/test/java/org/apache/ambari/server/orm/InMemoryDefaultTestModule.java
c9a392d 
>   ambari-server/src/test/java/org/apache/ambari/server/orm/JdbcPropertyTest.java 4a1f1fc

>   ambari-server/src/test/java/org/apache/ambari/server/security/authorization/AuthorizationTestModule.java
2781f59 
>   ambari-server/src/test/java/org/apache/ambari/server/security/authorization/AuthorizationTestModuleForLdapDNWithSpace.java
62c7a1b 
>   ambari-server/src/test/java/org/apache/ambari/server/upgrade/UpgradeTest.java b70d252

>   ambari-server/src/test/python/TestOSCheck.py a51d30f 
>   ambari-server/src/test/resources/os_family.json PRE-CREATION 
>   ambari-server/src/test/resources/stacks/HDP/0.1/repos/repoinfo.xml 199710f 
>   ambari-server/src/test/resources/stacks/HDP/0.2/repos/repoinfo.xml 4af41ae 
>   ambari-server/src/test/resources/stacks/HDP/1.2.0/repos/repoinfo.xml 7c3b691 
>   ambari-server/src/test/resources/stacks/HDP/1.3.0/repos/repoinfo.xml cff983a 
>   ambari-server/src/test/resources/stacks/HDP/1.3.1/repos/repoinfo.xml f5c0fee 
>   ambari-server/src/test/resources/stacks/HDP/2.0.1/repos/repoinfo.xml d429a85 
>   ambari-server/src/test/resources/stacks/HDP/2.0.5/repos/repoinfo.xml 7925e9e 
>   ambari-server/src/test/resources/stacks/HDP/2.0.6/repos/repoinfo.xml 5c5d414 
>   ambari-server/src/test/resources/stacks/HDP/2.0.7/repos/repoinfo.xml 0799343 
>   ambari-server/src/test/resources/stacks/HDP/2.0.8/repos/repoinfo.xml 1025240 
>   ambari-server/src/test/resources/stacks/HDP/2.1.1/repos/repoinfo.xml 44ca5c8 
>   contrib/ambari-scom/metrics-sink/pom.xml c7c2525 
> 
> Diff: https://reviews.apache.org/r/22972/diff/
> 
> 
> Testing
> -------
> 
> [INFO] Rat check: Summary of files. Unapproved: 0 unknown: 0 generated: 0 approved: 31
licence.
> [INFO] ------------------------------------------------------------------------
> [INFO] Reactor Summary:
> [INFO] 
> [INFO] Ambari Main ....................................... SUCCESS [1.864s]
> [INFO] Apache Ambari Project POM ......................... SUCCESS [0.279s]
> [INFO] Ambari Web ........................................ SUCCESS [9.955s]
> [INFO] Ambari Views ...................................... SUCCESS [1.727s]
> [INFO] Ambari Server ..................................... SUCCESS [14:23.217s]
> [INFO] Ambari Agent ...................................... SUCCESS [9.237s]
> [INFO] Ambari Client ..................................... SUCCESS [0.032s]
> [INFO] Ambari Python Client .............................. SUCCESS [0.258s]
> [INFO] Ambari Groovy Client .............................. SUCCESS [8.667s]
> [INFO] Ambari Shell ...................................... SUCCESS [4.931s]
> [INFO] ------------------------------------------------------------------------
> [INFO] BUILD SUCCESS
> [INFO] ------------------------------------------------------------------------
> [INFO] Total time: 15:00.682s
> [INFO] Finished at: Wed Jun 25 15:05:13 EEST 2014
> [INFO] Final Memory: 66M/1153M
> [INFO] ------------------------------------------------------------------------
> 
> 
> Thanks,
> 
> Andrew Onischuk
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message