ambari-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Tom Beerbower" <tbeerbo...@hortonworks.com>
Subject Review Request 26729: Views: Masked property not encoded on newly created instance
Date Wed, 15 Oct 2014 02:41:05 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/26729/
-----------------------------------------------------------

Review request for Ambari and Srimanth Gunturi.


Bugs: AMBARI-7768
    https://issues.apache.org/jira/browse/AMBARI-7768


Repository: ambari


Description
-------

Reopen AMBARI-7768.

Update view instance causes mask to be reapplied to existing properties.  Move the mask operation
for create/update to the resource provider so that it is only applied to new property values.


Diffs
-----

  ambari-server/src/main/java/org/apache/ambari/server/controller/internal/ViewInstanceResourceProvider.java
158f66d 
  ambari-server/src/main/java/org/apache/ambari/server/view/ViewRegistry.java 1e28e62 
  ambari-server/src/test/java/org/apache/ambari/server/controller/internal/ViewInstanceResourceProviderTest.java
c0ecddc 
  ambari-server/src/test/java/org/apache/ambari/server/view/ViewRegistryTest.java 00da1bb


Diff: https://reviews.apache.org/r/26729/diff/


Testing
-------

Manual tests.

New tests added.  All tests pass.

Results :

Tests run: 2170, Failures: 0, Errors: 0, Skipped: 17

…

[INFO] ------------------------------------------------------------------------
[INFO] BUILD SUCCESS
[INFO] ------------------------------------------------------------------------
[INFO] Total time: 44:30.202s
[INFO] Finished at: Tue Oct 14 22:32:01 EDT 2014
[INFO] Final Memory: 45M/283M
[INFO] ------------------------------------------------------------------------


Thanks,

Tom Beerbower


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message