ambari-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Jonathan Hurley" <jhur...@hortonworks.com>
Subject Re: Review Request 26654: ldap sync: require --all option
Date Tue, 14 Oct 2014 01:55:50 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/26654/#review56482
-----------------------------------------------------------

Ship it!


Ship It!

- Jonathan Hurley


On Oct. 13, 2014, 2:33 p.m., Tom Beerbower wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/26654/
> -----------------------------------------------------------
> 
> (Updated Oct. 13, 2014, 2:33 p.m.)
> 
> 
> Review request for Ambari, Alejandro Fernandez and Jonathan Hurley.
> 
> 
> Bugs: AMBARI-7760
>     https://issues.apache.org/jira/browse/AMBARI-7760
> 
> 
> Repository: ambari
> 
> 
> Description
> -------
> 
> To avoid accidentally sync'ing all ldap, we need to add a "--all" option to sync-ldap.
This could cause a lot of pain if users call sync-ldap w/o scoping users and groups.
> Then, by default, sync-ldap now requires minimally 1 argument.
> 
> 
> Diffs
> -----
> 
>   ambari-server/src/main/python/ambari-server.py 5480399 
>   ambari-server/src/test/python/TestAmbariServer.py 49bfb3d 
> 
> Diff: https://reviews.apache.org/r/26654/diff/
> 
> 
> Testing
> -------
> 
> Manual test all sync modes.
> 
> Added new unit tests.  All existing tests pass.
> 
> [INFO] ------------------------------------------------------------------------
> [INFO] BUILD SUCCESS
> [INFO] ------------------------------------------------------------------------
> [INFO] Total time: 36:32.439s
> [INFO] Finished at: Mon Oct 13 14:30:21 EDT 2014
> [INFO] Final Memory: 29M/224M
> [INFO] ------------------------------------------------------------------------
> 
> 
> Thanks,
> 
> Tom Beerbower
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message