ambari-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Oleg Nechiporenko" <onechipore...@apache.org>
Subject Re: Review Request 26648: Storm Start fails because of malformed childopts
Date Mon, 13 Oct 2014 16:36:24 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/26648/#review56409
-----------------------------------------------------------

Ship it!


Ship It!

- Oleg Nechiporenko


On Oct. 13, 2014, 4:35 p.m., Andriy Babiichuk wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/26648/
> -----------------------------------------------------------
> 
> (Updated Oct. 13, 2014, 4:35 p.m.)
> 
> 
> Review request for Ambari, Aleksandr Kovalenko and Oleg Nechiporenko.
> 
> 
> Bugs: AMBARI-7759
>     https://issues.apache.org/jira/browse/AMBARI-7759
> 
> 
> Repository: ambari
> 
> 
> Description
> -------
> 
> UI sends some configs from storm-site wrongly formatted:
> {noformat}
> "supervisor.childopts" : "-Xmx256m _JAAS_PLACEHOLDER -Dcom.sun.management.jmxremote\n\t\t\t-Dcom.sun.management.jmxremote.ssl=false\n\t\t\t-Dcom.sun.management.jmxremote.authenticate=false\n\t\t\t-Dcom.sun.management.jmxremote.port=56431\n\t\t\t-javaagent:/usr/hdp/current/storm-supervisor/contrib/storm-jmxetric/lib/jmxetric-1.0.4.jar=host=localhost,port=8650,wireformat31x=true,mode=multicast,config=/usr/hdp/current/storm-supervisor/contrib/storm-jmxetric/conf/jmxetric-conf.xml,process=Supervisor_JVM"
> 
> 
> "nimbus.childopts" : "-Xmx1024m _JAAS_PLACEHOLDER\n\t\t\t-javaagent:/usr/hdp/current/storm-nimbus/contrib/storm-jmxetric/lib/jmxetric-1.0.4.jar=host=localhost,port=8649,wireformat31x=true,mode=multicast,config=/usr/hdp-nimbus/current/storm-client/contrib/storm-jmxetric/conf/jmxetric-conf.xml,process=Nimbus_JVM"
> 
> 
> "logviewer.childopts" : "-Xmx128m _JAAS_PLACEHOLDER",
> 
> "drpc.childopts" : "-Xmx768m _JAAS_PLACEHOLDER",
> 
> "worker.childopts" : "-Xmx768m _JAAS_PLACEHOLDER\n\t\t\t-javaagent:/usr/hdp/current/storm-client/contrib/storm-jmxetric/lib/jmxetric-1.0.4.jar=host=localhost,port=8650,wireformat31x=true,mode=multicast,config=/usr/hdp/current/storm-client/contrib/storm-jmxetric/conf/jmxetric-conf.xml,process=Worker_%ID%_JVM",
> 
> "ui.childopts" : "-Xmx768m _JAAS_PLACEHOLDER",
> {noformat}
> 
> We don't wont those \n\t\t\t. UI should send value with those replaced by tabs spaces
etc.
> 
> 
> Diffs
> -----
> 
>   ambari-web/app/controllers/wizard/step8_controller.js b975f01 
>   ambari-web/test/controllers/wizard/step8_test.js 3f061d0 
> 
> Diff: https://reviews.apache.org/r/26648/diff/
> 
> 
> Testing
> -------
> 
> 1 test added;
> 1 test removed
> 
> 
> Thanks,
> 
> Andriy Babiichuk
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message