ambari-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Andrii Tkach" <atk...@hortonworks.com>
Subject Re: Review Request 26599: Slider View: set admin password param as masked
Date Sun, 12 Oct 2014 13:33:54 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/26599/#review56346
-----------------------------------------------------------

Ship it!


Ship It!

- Andrii Tkach


On Окт. 11, 2014, 3:56 п.п., Andriy Babiichuk wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/26599/
> -----------------------------------------------------------
> 
> (Updated Окт. 11, 2014, 3:56 п.п.)
> 
> 
> Review request for Ambari and Oleg Nechiporenko.
> 
> 
> Bugs: AMBARI-7746
>     https://issues.apache.org/jira/browse/AMBARI-7746
> 
> 
> Repository: ambari
> 
> 
> Description
> -------
> 
> https://github.com/apache/ambari/blob/trunk/contrib/views/slider/src/main/resources/view.xml
> 
> Need to set this paramater as <masked>true</masked>
> 
> {code}
> 	<parameter>
> <name>ambari.server.password</name>
> <description>Ambari administrator password (for example: admin)
> </description>
> <required>true</required>
> </parameter>
> {code}
> 
> 
> Also, change the descriptions on these properties:
> 
> |ambari.server.username|Cluster Operator username (for example: admin)|
> |ambari.server.password|
> |Cluster Operator password (for example: admin)|
> 
> Because you don't need to be an ambari admin, you need to be at least a cluster operator.
> 
> 
> Diffs
> -----
> 
>   contrib/views/slider/src/main/resources/view.xml 5dcc397 
> 
> Diff: https://reviews.apache.org/r/26599/diff/
> 
> 
> Testing
> -------
> 
> didn't add tests - small xml changes
> 
> 
> Thanks,
> 
> Andriy Babiichuk
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message