ambari-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Jonathan Hurley" <jhur...@hortonworks.com>
Subject Re: Review Request 26568: Alerts: Create REST API Endpoint for Alert History
Date Sun, 12 Oct 2014 04:33:31 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/26568/
-----------------------------------------------------------

(Updated Oct. 12, 2014, 12:33 a.m.)


Review request for Ambari, Nate Cole and Tom Beerbower.


Changes
-------

Thanks for the review! 

- Moved Alert\* property declarations out of JSON files and into static{} blocks of their
respective ResourceProviders.
- Is it wrong that the AlertHistoryResourceDefinition specifies "alert_history" for both singular
and plural?
- Fixed the annotation import


Bugs: AMBARI-7734
    https://issues.apache.org/jira/browse/AMBARI-7734


Repository: ambari


Description
-------

Alert history is exposed as read-only. Since this data can grow without bounds, the current
API model of manipulating the entire result set in memory is not viable long term. 

This patch will pass the Ambari Predicate down to the DAO which will then turn the Predicate
into a JPA Predicate capable of being handed to a CriteriaQuery. This will allow JPA to do
most of the work in reducing the requested result set.

Missing from this are pagination and sorting. That will be a separate change coming next where
the ResourceProviders are given both, and if possible, can apply them to the result set they
return.


Diffs (updated)
-----

  ambari-server/src/main/java/org/apache/ambari/server/api/query/JpaPredicateVisitor.java
PRE-CREATION 
  ambari-server/src/main/java/org/apache/ambari/server/api/resources/AlertHistoryResourceDefinition.java
PRE-CREATION 
  ambari-server/src/main/java/org/apache/ambari/server/api/resources/ResourceInstanceFactoryImpl.java
74580a4 
  ambari-server/src/main/java/org/apache/ambari/server/api/services/AlertHistoryService.java
PRE-CREATION 
  ambari-server/src/main/java/org/apache/ambari/server/api/services/ClusterService.java a56bcbf

  ambari-server/src/main/java/org/apache/ambari/server/controller/AlertHistoryRequest.java
PRE-CREATION 
  ambari-server/src/main/java/org/apache/ambari/server/controller/AmbariServer.java e0de383

  ambari-server/src/main/java/org/apache/ambari/server/controller/internal/AbstractControllerResourceProvider.java
5810633 
  ambari-server/src/main/java/org/apache/ambari/server/controller/internal/AlertDefinitionResourceProvider.java
1de49a7 
  ambari-server/src/main/java/org/apache/ambari/server/controller/internal/AlertGroupResourceProvider.java
8c55aa7 
  ambari-server/src/main/java/org/apache/ambari/server/controller/internal/AlertHistoryResourceProvider.java
PRE-CREATION 
  ambari-server/src/main/java/org/apache/ambari/server/controller/internal/AlertTargetResourceProvider.java
b0cc52b 
  ambari-server/src/main/java/org/apache/ambari/server/controller/internal/DefaultProviderModule.java
ab89db2 
  ambari-server/src/main/java/org/apache/ambari/server/controller/spi/Resource.java f51375b

  ambari-server/src/main/java/org/apache/ambari/server/orm/dao/AlertsDAO.java f2161f3 
  ambari-server/src/main/java/org/apache/ambari/server/orm/entities/AlertHistoryEntity_.java
PRE-CREATION 
  ambari-server/src/main/resources/key_properties.json 085dc11 
  ambari-server/src/main/resources/properties.json 8a0a58a 
  ambari-server/src/test/java/org/apache/ambari/server/controller/internal/AlertDefinitionResourceProviderTest.java
78655dd 
  ambari-server/src/test/java/org/apache/ambari/server/controller/internal/AlertGroupResourceProviderTest.java
771bf8a 
  ambari-server/src/test/java/org/apache/ambari/server/controller/internal/AlertHistoryResourceProviderTest.java
PRE-CREATION 
  ambari-server/src/test/java/org/apache/ambari/server/controller/internal/AlertTargetResourceProviderTest.java
b96a4f3 
  ambari-server/src/test/java/org/apache/ambari/server/orm/dao/AlertsDAOTest.java a2023d8


Diff: https://reviews.apache.org/r/26568/diff/


Testing
-------

[INFO] ------------------------------------------------------------------------
[INFO] BUILD SUCCESS
[INFO] ------------------------------------------------------------------------
[INFO] Total time: 23:24 min
[INFO] Finished at: 2014-10-10T14:45:44-04:00
[INFO] Final Memory: 29M/230M
[INFO] ------------------------------------------------------------------------


Thanks,

Jonathan Hurley


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message