ambari-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Oleg Nechiporenko" <onechipore...@apache.org>
Subject Re: Review Request 26598: Admin View: include Views icon in header and link to /#/main/views in web
Date Sat, 11 Oct 2014 12:15:22 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/26598/#review56286
-----------------------------------------------------------

Ship it!


Ship It!

- Oleg Nechiporenko


On Oct. 11, 2014, 12:01 p.m., Andriy Babiichuk wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/26598/
> -----------------------------------------------------------
> 
> (Updated Oct. 11, 2014, 12:01 p.m.)
> 
> 
> Review request for Ambari, Andrii Tkach and Oleg Nechiporenko.
> 
> 
> Bugs: AMBARI-7744
>     https://issues.apache.org/jira/browse/AMBARI-7744
> 
> 
> Repository: ambari
> 
> 
> Description
> -------
> 
> In the Admin View:
> 
> Show the Views icon/pulldown in the upper right header.  The look and feel and behavior
should exactly match that of Ambari Web (i.e., clicking on the Icon itself links to Ambari
Web Views landing page /#/main/views, or clicking on specific View instance takes the user
to that view instance UI).
> Make sure that users with different privileges are covered and works exactly the same
way as in Ambari Web (AMBARI.ADMIN should be able to see all view instances except for "system"
views, etc) 
> 
> 
> Diffs
> -----
> 
>   ambari-admin/src/main/resources/ui/admin-web/app/index.html 1b517d5 
>   ambari-admin/src/main/resources/ui/admin-web/app/scripts/controllers/mainCtrl.js 2a5c64b

>   ambari-admin/src/main/resources/ui/admin-web/app/scripts/services/View.js 20fe59f 
>   ambari-admin/src/main/resources/ui/admin-web/app/styles/main.css b6189f8 
>   ambari-admin/src/main/resources/ui/admin-web/test/unit/controllers/mainCtrl_test.js
c66d96e 
> 
> Diff: https://reviews.apache.org/r/26598/diff/
> 
> 
> Testing
> -------
> 
> 1 test added
> 
> 
> Thanks,
> 
> Andriy Babiichuk
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message