ambari-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Sid Wagle" <swa...@hortonworks.com>
Subject Re: Review Request 26511: Slider service should specify what client configs can be downloaded
Date Thu, 09 Oct 2014 19:42:38 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/26511/#review56039
-----------------------------------------------------------

Ship it!


Ship It!

- Sid Wagle


On Oct. 9, 2014, 7:42 p.m., Sumit Mohanty wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/26511/
> -----------------------------------------------------------
> 
> (Updated Oct. 9, 2014, 7:42 p.m.)
> 
> 
> Review request for Ambari and Sid Wagle.
> 
> 
> Bugs: AMBARI-7713
>     https://issues.apache.org/jira/browse/AMBARI-7713
> 
> 
> Repository: ambari
> 
> 
> Description
> -------
> 
> Slider service should specify what client configs can be downloaded. Some minor changes
such as dropping property "slider.yarn.queue" and moving the slider-env.sh to a configurable
template.
> 
> 
> Diffs
> -----
> 
>   ambari-server/src/main/resources/stacks/HDP/2.2/services/SLIDER/configuration/slider-client.xml
7d55760 
>   ambari-server/src/main/resources/stacks/HDP/2.2/services/SLIDER/configuration/slider-env.xml
PRE-CREATION 
>   ambari-server/src/main/resources/stacks/HDP/2.2/services/SLIDER/metainfo.xml 946fad8

>   ambari-server/src/main/resources/stacks/HDP/2.2/services/SLIDER/package/scripts/params.py
3b12f9b 
>   ambari-server/src/main/resources/stacks/HDP/2.2/services/SLIDER/package/scripts/slider.py
a3b6238 
>   ambari-server/src/main/resources/stacks/HDP/2.2/services/SLIDER/package/templates/slider-env.sh.j2
4872e29 
>   ambari-server/src/test/python/stacks/2.2/SLIDER/test_slider_client.py c89e73c 
>   ambari-server/src/test/python/stacks/2.2/configs/default.json 2fbed67 
>   ambari-server/src/test/python/stacks/2.2/configs/secured.json 3080043 
> 
> Diff: https://reviews.apache.org/r/26511/diff/
> 
> 
> Testing
> -------
> 
> Manually tested by deploying Sldier with modified definition. Ran all the python unit
tests.
> 
> 
> Thanks,
> 
> Sumit Mohanty
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message