ambari-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Grace Li" <...@pivotal.io>
Subject Re: Review Request 26452: HDFS config will not save
Date Wed, 08 Oct 2014 19:47:56 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/26452/#review55869
-----------------------------------------------------------

Ship it!


Ship It!

- Grace Li


On Oct. 8, 2014, 7:04 p.m., Thulasi Nandakumaran wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/26452/
> -----------------------------------------------------------
> 
> (Updated Oct. 8, 2014, 7:04 p.m.)
> 
> 
> Review request for Ambari.
> 
> 
> Bugs: AMBARI-7639
>     https://issues.apache.org/jira/browse/AMBARI-7639
> 
> 
> Repository: ambari
> 
> 
> Description
> -------
> 
> When modifying the HDS config or adding new properties, no success dialog appears. The
save button would then be disabled as though save was successful. When trying to switch tabs,
a dialogue would appear suggesting that there are unsaved changes.
> 
> 
> Diffs
> -----
> 
>   ambari-web/app/controllers/main/service/info/configs.js 2210920 
>   ambari-web/test/controllers/main/service/info/config_test.js e11ad38 
> 
> Diff: https://reviews.apache.org/r/26452/diff/
> 
> 
> Testing
> -------
> 
> In configs_test.js, tests for method isDirChanged have been added.
> 
> 
> Thanks,
> 
> Thulasi Nandakumaran
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message