ambari-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Grace Li" <...@pivotal.io>
Subject Re: Review Request 26451: Correct evident spelling and grammatical errors in global strings
Date Wed, 08 Oct 2014 19:01:05 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/26451/#review55855
-----------------------------------------------------------

Ship it!


Ship It!

- Grace Li


On Oct. 8, 2014, 6:56 p.m., Thulasi Nandakumaran wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/26451/
> -----------------------------------------------------------
> 
> (Updated Oct. 8, 2014, 6:56 p.m.)
> 
> 
> Review request for Ambari.
> 
> 
> Bugs: AMBARI-7638
>     https://issues.apache.org/jira/browse/AMBARI-7638
> 
> 
> Repository: ambari
> 
> 
> Description
> -------
> 
> Background Operations popup has "Background Operations" pluralized when there is only
1 operation.
> Constants and Labels in messages.js have spelling errors.
> 
> 
> Diffs
> -----
> 
>   ambari-web/app/controllers/main/host/details.js 98819e4 
>   ambari-web/app/controllers/wizard/step0_controller.js dd7935d 
>   ambari-web/app/messages.js 34cee7d 
>   ambari-web/app/utils/host_progress_popup.js 1e2c675 
>   ambari-web/test/utils/host_progress_popup_test.js 3a8a1c1 
> 
> Diff: https://reviews.apache.org/r/26451/diff/
> 
> 
> Testing
> -------
> 
> Unit test for setBackgroundOperatorHeader to test Background Operation label.
> 
> 
> Thanks,
> 
> Thulasi Nandakumaran
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message