ambari-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Myroslav Papirkovskyy" <mpapyrkovs...@hortonworks.com>
Subject Re: Review Request 24845: Config_data column should be consistent across tables
Date Wed, 08 Oct 2014 15:59:53 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/24845/#review55802
-----------------------------------------------------------

Ship it!


Ship It!

- Myroslav Papirkovskyy


On Жов. 8, 2014, 6:59 після полудня, Dmytro Sen wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/24845/
> -----------------------------------------------------------
> 
> (Updated Жов. 8, 2014, 6:59 після полудня)
> 
> 
> Review request for Ambari and Myroslav Papirkovskyy.
> 
> 
> Bugs: AMBARI-6911
>     https://issues.apache.org/jira/browse/AMBARI-6911
> 
> 
> Repository: ambari
> 
> 
> Description
> -------
> 
> config_data column has different types in different tables in MySQL and Postgres.
> MySQL
> clusterconfig - LONGTEXT
> blueprint_configuration - VARCHAR(32000)
> hostgroup_configuration - TEXT
> Postgres & embedded
> clusterconfig - VARCHAR(32000)
> blueprint_configuration - varchar(32000)
> hostgroup_configuration - TEXT
> If we want this fixed, we should take care of upgrading Ambari also.
> MySQL should be mapped to LONGTEXT
> Postrges to TEXT
> Oracle to CLOB
> 
> 
> Diffs
> -----
> 
>   ambari-server/src/main/java/org/apache/ambari/server/orm/entities/BlueprintConfigEntity.java
1495704 
>   ambari-server/src/main/java/org/apache/ambari/server/orm/entities/ClusterConfigEntity.java
da8fac6 
>   ambari-server/src/main/java/org/apache/ambari/server/orm/entities/HostGroupConfigEntity.java
cc4e0c6 
>   ambari-server/src/main/java/org/apache/ambari/server/upgrade/UpgradeCatalog160.java
d3fdd3b 
>   ambari-server/src/main/java/org/apache/ambari/server/upgrade/UpgradeCatalog170.java
144900e 
>   ambari-server/src/main/resources/Ambari-DDL-MySQL-CREATE.sql fe39612 
>   ambari-server/src/main/resources/Ambari-DDL-Postgres-CREATE.sql 25d973f 
>   ambari-server/src/main/resources/Ambari-DDL-Postgres-EMBEDDED-CREATE.sql 2d5b267 
>   ambari-server/src/test/java/org/apache/ambari/server/upgrade/UpgradeCatalog160Test.java
515f8cd 
>   ambari-server/src/test/java/org/apache/ambari/server/upgrade/UpgradeCatalog170Test.java
6262a2b 
> 
> Diff: https://reviews.apache.org/r/24845/diff/
> 
> 
> Testing
> -------
> 
> Unit tests + manually deployed on Mysql, Oracle, Postgres, Postgres-Embedded , tested
upgrade on Postgres 1.6.0 -> 1.6.1 > 1.7.0, 1.6.1 -> 1.7.0, 1.6.0 -> 1.7.0
> 
> [INFO] ------------------------------------------------------------------------
> [INFO] BUILD SUCCESS
> [INFO] ------------------------------------------------------------------------
> [INFO] Total time: 21:45.128s
> 
> 
> Thanks,
> 
> Dmytro Sen
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message