ambari-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Alejandro Fernandez" <afernan...@hortonworks.com>
Subject Re: Review Request 26234: Failure handling of downloading client configs
Date Tue, 07 Oct 2014 18:06:43 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/26234/#review55669
-----------------------------------------------------------

Ship it!


Ship It!

- Alejandro Fernandez


On Oct. 1, 2014, 5:21 p.m., Andrew Onischuk wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/26234/
> -----------------------------------------------------------
> 
> (Updated Oct. 1, 2014, 5:21 p.m.)
> 
> 
> Review request for Ambari and Dmitro Lisnichenko.
> 
> 
> Bugs: AMBARI-7596
>     https://issues.apache.org/jira/browse/AMBARI-7596
> 
> 
> Repository: ambari
> 
> 
> Description
> -------
> 
> We should log output of the executed python commands, also stderr, and check
> the return code of them.
> 
> If it's not 0 we should throw exception, or warning message to the server
> logs, which would contain the reason of failure (the python expection message
> without stack trace).
> 
> In that case we should return like 500 error code. Not to give malformed
> configs to the customers, and to do early failing which is helpful.
> 
> 
> Diffs
> -----
> 
>   ambari-server/src/main/java/org/apache/ambari/server/controller/internal/ClientConfigResourceProvider.java
1caae37e 
>   ambari-server/src/test/java/org/apache/ambari/server/controller/internal/ClientConfigResourceProviderTest.java
ef094b5 
> 
> Diff: https://reviews.apache.org/r/26234/diff/
> 
> 
> Testing
> -------
> 
> mvn clean test
> 
> 
> Thanks,
> 
> Andrew Onischuk
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message