ambari-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Srimanth Gunturi" <srima...@hortonworks.com>
Subject Re: Review Request 26326: Jobs View proxy does not apply all URL query params
Date Fri, 03 Oct 2014 20:15:44 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/26326/#review55386
-----------------------------------------------------------


I think this is a UI request issue. 

When the UI makes the call, the value of parameter 'url' should be escaped. That will make
the entire value (along with & as one value). If not escaped, the internal URL's params
end up as top level param.

- Srimanth Gunturi


On Oct. 3, 2014, 7:38 p.m., Alejandro Fernandez wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/26326/
> -----------------------------------------------------------
> 
> (Updated Oct. 3, 2014, 7:38 p.m.)
> 
> 
> Review request for Ambari, Jaimin Jetly, Srimanth Gunturi, Tom Beerbower, and Yusaku
Sako.
> 
> 
> Bugs: AMBARI-7641
>     https://issues.apache.org/jira/browse/AMBARI-7641
> 
> 
> Repository: ambari
> 
> 
> Description
> -------
> 
> The Jobs view should only show Tez jobs.
> This is a bug in Ambari after switching to the Views proxy instead of the generic proxy.
> E.g., 
> http://server:8188/ws/v1/timeline/HIVE_QUERY_ID?fields=events,primaryfilters,otherinfo&secondaryFilter=tez:true
> returns only the tez jobs, as expected
> http://viewserver:8080/views/JOBS/1.0.0/instance/proxy?url=http://server:8188/ws/v1/timeline/HIVE_QUERY_ID?fields=events,primaryfilters,otherinfo&secondaryFilter=tez:true
> seems to interpret "&secondaryFilter=tez:true" as a parameter to the proxy endpoint,
and not as part of the string that makes up the "url" query parameter.
> 
> 
> Diffs
> -----
> 
>   contrib/views/jobs/src/main/java/org/apache/ambari/view/jobs/ProxyServlet.java f02844e

> 
> Diff: https://reviews.apache.org/r/26326/diff/
> 
> 
> Testing
> -------
> 
> Built the view and verified it works after deploying the jar file.
> 
> 
> Thanks,
> 
> Alejandro Fernandez
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message