ambari-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "jun aoki" <jun.aoki....@gmail.com>
Subject Re: Review Request 26057: AMBARI-7442 ServiceCheck cannot be run if there is only one stack definition
Date Fri, 03 Oct 2014 01:24:15 GMT


> On Oct. 3, 2014, 1:23 a.m., jun aoki wrote:
> > ambari-server/src/main/java/org/apache/ambari/server/api/util/StackExtensionHelper.java,
line 431
> > <https://reviews.apache.org/r/26057/diff/1/?file=705685#file705685line431>
> >
> >     Thank you Sid for your comment.
> >     Correct me if I don't get it.
> >     
> >     AmbariMetaInfo#getConfigurationInformation calls a set of StackExtentionHelper's
methods in order of fillInfo(), getAllAvailableStacks() and getAllApplicableServices()
> >     
> >     And you are suggesting 
> >     1. Delete existing actionMetadata#addServceCheckAction (line 488) from getAllApplicableServices()
> >     ```
> >     actionMetadata.addServiceCheckAction(serviceInfo.getName())
> >     ```
> >     2. Not add another actionMetadata defined in the current patch
> >     3. Add actionMetadata in populateServicesForStack() because 
> >     fillInfo() calls getStackInfo() which calls populateServicesForStack() 
> >     
> >     The logic that will be added to populateServicesForStack is same 
> >     1. Look for parents, 
> >     2. if parents do not exist loop the given stackInfo's services, 
> >     3. If parents exist, loop with the parent's services.
> >     
> >     
> >     can you also take a look my comment in the JIRA?
> >     
> >     https://issues.apache.org/jira/browse/AMBARI-7442?focusedCommentId=14157221&page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comment-14157221

This is more of a response to Sid's comment above.


- jun


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/26057/#review55306
-----------------------------------------------------------


On Sept. 29, 2014, 8:44 p.m., Alexander Denissov wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/26057/
> -----------------------------------------------------------
> 
> (Updated Sept. 29, 2014, 8:44 p.m.)
> 
> 
> Review request for Ambari, Mahadev Konar and Newton Alex.
> 
> 
> Bugs: AMBARI-7442
>     https://issues.apache.org/jira/browse/AMBARI-7442
> 
> 
> Repository: ambari
> 
> 
> Description
> -------
> 
> ServiceCheck cannot be run if there is only one stack definition in the stack family
> 
> 
> Diffs
> -----
> 
>   ambari-server/src/main/java/org/apache/ambari/server/api/util/StackExtensionHelper.java
fe6c6bc 
>   ambari-server/src/test/java/org/apache/ambari/server/api/util/StackExtensionHelperTest.java
74761dd 
>   ambari-server/src/test/resources/single_stack/ABC/1.0.0/metainfo.xml PRE-CREATION 
>   ambari-server/src/test/resources/single_stack/ABC/1.0.0/services/HDFS/metainfo.xml
PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/26057/diff/
> 
> 
> Testing
> -------
> 
> tested the fix against a cluster
> 
> 
> Thanks,
> 
> Alexander Denissov
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message