ambari-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Tom Beerbower" <tbeerbo...@hortonworks.com>
Subject Re: Review Request 26248: Views: the "properties" object should only be accessible from REST API if AMBARI.ADMIN
Date Thu, 02 Oct 2014 12:34:17 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/26248/
-----------------------------------------------------------

(Updated Oct. 2, 2014, 12:34 p.m.)


Review request for Ambari, Alejandro Fernandez and Jonathan Hurley.


Changes
-------

Review changes


Bugs: AMBARI-7598
    https://issues.apache.org/jira/browse/AMBARI-7598


Repository: ambari


Description
-------

/api/v1/views/FILES/versions/0.1.0/instances/FILES_1

Configuration properties for a view instance should only be accessible from the Views REST
API if you are an AMBARI.ADMIN. This protects view instance config props info from regular
users of a view. If a view client-side happens to need access to these properties for some
reason, they should implement a server-side resource in their view that exposes this information.

{code}
    "properties" : {
      "dataworker.defaultFs" : "webhdfs://c6401.ambari.apache.org:50070",
      "dataworker.username" : null
    }
{code}


Diffs (updated)
-----

  ambari-server/src/main/java/org/apache/ambari/server/controller/internal/ViewInstanceResourceProvider.java
9a48b41 
  ambari-server/src/main/java/org/apache/ambari/server/view/ViewRegistry.java e48c88e 
  ambari-server/src/test/java/org/apache/ambari/server/controller/internal/ViewInstanceResourceProviderTest.java
8f34916 

Diff: https://reviews.apache.org/r/26248/diff/


Testing
-------

Manual tests.

Updated unit tests.  All existing tests pass ...

Results :

Tests run: 2076, Failures: 0, Errors: 0, Skipped: 16
…


[INFO] ------------------------------------------------------------------------
[INFO] BUILD SUCCESS
[INFO] ------------------------------------------------------------------------
[INFO] Total time: 38:14.386s
[INFO] Finished at: Wed Oct 01 16:54:39 EDT 2014
[INFO] Final Memory: 38M/423M
[INFO] ------------------------------------------------------------------------


Thanks,

Tom Beerbower


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message