ambari-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Robert Levas <rle...@hortonworks.com>
Subject Re: Review Request 26952: ShellCommandUtil.Results class should be public, not package private
Date Thu, 23 Oct 2014 15:08:42 GMT

Please review my small change.  It’s only a few lines and if it could be done by the end
of this week I would be very appreciative. 

Thanks

Rob


On Oct 22, 2014, at 3:51 PM, Robert Levas <rlevas@hortonworks.com> wrote:

> 
> This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/26952/
> 
> Review request for Ambari and John Speidel.
> By Robert Levas.
> Updated Oct. 22, 2014, 3:51 p.m.
> 
> Bugs: AMBARI-7870
> Repository: ambari
> Description
> 
> ShellCommandUtil.Results class should be public, not package private. Because it is package
private, any ShellCommandUtil public methods returning a ShellCommandUtil.Results is basically
unusable outside of the org.apache.ambari.server.utils package.
> Solution:  Make ShellCommandUtil.Results and its methods explicitly public
> Diffs
> 
> ambari-server/src/main/java/org/apache/ambari/server/utils/ShellCommandUtil.java (ee83aa0)
> ambari-server/src/test/java/org/apache/ambari/server/utils/TestShellCommandUtil.java
(27a033c)
> View Diff
> 


-- 
CONFIDENTIALITY NOTICE
NOTICE: This message is intended for the use of the individual or entity to 
which it is addressed and may contain information that is confidential, 
privileged and exempt from disclosure under applicable law. If the reader 
of this message is not the intended recipient, you are hereby notified that 
any printing, copying, dissemination, distribution, disclosure or 
forwarding of this communication is strictly prohibited. If you have 
received this communication in error, please contact the sender immediately 
and delete it from your system. Thank You.

Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message