Return-Path: X-Original-To: apmail-ambari-dev-archive@www.apache.org Delivered-To: apmail-ambari-dev-archive@www.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id CE038114AA for ; Fri, 19 Sep 2014 10:47:34 +0000 (UTC) Received: (qmail 31345 invoked by uid 500); 19 Sep 2014 10:47:34 -0000 Delivered-To: apmail-ambari-dev-archive@ambari.apache.org Received: (qmail 31292 invoked by uid 500); 19 Sep 2014 10:47:34 -0000 Mailing-List: contact dev-help@ambari.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@ambari.apache.org Delivered-To: mailing list dev@ambari.apache.org Received: (qmail 31007 invoked by uid 99); 19 Sep 2014 10:47:34 -0000 Received: from arcas.apache.org (HELO arcas.apache.org) (140.211.11.28) by apache.org (qpsmtpd/0.29) with ESMTP; Fri, 19 Sep 2014 10:47:34 +0000 Date: Fri, 19 Sep 2014 10:47:33 +0000 (UTC) From: "Hudson (JIRA)" To: dev@ambari.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Commented] (AMBARI-7400) Slider View: Most view parameters should be made required MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 [ https://issues.apache.org/jira/browse/AMBARI-7400?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14140306#comment-14140306 ] Hudson commented on AMBARI-7400: -------------------------------- SUCCESS: Integrated in Ambari-trunk-Commit #306 (See [https://builds.apache.org/job/Ambari-trunk-Commit/306/]) AMBARI-7400. Slider View: Most view parameters should be made required. (onechiporenko) (onechiporenko: http://git-wip-us.apache.org/repos/asf?p=ambari.git&a=commit&h=d62147ed37864f7f9f321448c3036ade0eeb681f) * contrib/views/slider/src/main/resources/ui/app/controllers/slider_controller.js * contrib/views/slider/src/main/resources/view.xml * contrib/views/slider/src/main/resources/ui/app/templates/slider_title_tooltip.hbs * contrib/views/slider/src/main/resources/ui/config.js * contrib/views/slider/src/main/resources/ui/app/views/application_view.js * contrib/views/slider/src/main/resources/ui/app/templates/application.hbs * contrib/views/slider/src/main/resources/ui/app/assets/data/resource/empty_json.json * contrib/views/slider/src/main/resources/ui/app/helpers/ajax.js * contrib/views/slider/src/main/resources/ui/app/controllers/createAppWizard/step1_controller.js * contrib/views/slider/src/main/resources/ui/app/assets/data/resource/service_configs.json * contrib/views/slider/src/main/resources/ui/app/mappers/slider_apps_mapper.js * contrib/views/slider/src/main/resources/ui/app/initialize.js * contrib/views/slider/src/main/resources/ui/app/assets/data/resource/cluster_name.json * contrib/views/slider/src/main/resources/ui/app/models/slider_config.js * contrib/views/slider/src/main/resources/ui/app/translations.js * contrib/views/slider/src/main/resources/ui/vendor/scripts/common/tv4.js * contrib/views/slider/src/main/resources/ui/app/assets/data/resource/slider-properties.json * contrib/views/slider/src/main/resources/ui/app/assets/data/resource/service_status.json * contrib/views/slider/src/main/resources/ui/app/assets/data/resource/components_hosts.json * contrib/views/slider/src/main/resources/ui/app/routes/main.js > Slider View: Most view parameters should be made required > --------------------------------------------------------- > > Key: AMBARI-7400 > URL: https://issues.apache.org/jira/browse/AMBARI-7400 > Project: Ambari > Issue Type: Bug > Components: contrib > Affects Versions: 1.7.0 > Reporter: Oleg Nechiporenko > Assignee: Oleg Nechiporenko > Priority: Critical > Fix For: 1.7.0 > > Attachments: AMBARI-7400.patch > > > First, we should rename view parameters to below. Also we should mark them required as mentioned below. > * {{hdfs.url}}. Required = true > * {{yarn.rm.url}}. Required = true > * {{yarn.rm.scheduler.url}}. Required = true > * {{zookeeper.quorum}}. Required = true > * {{ganglia.host}}. Required = *false* > * {{ganglia.addtional.clusters}}. Required = *false* > * {{slider.user}}. Required = *false* (see BUG-23250) > The code on client to automatically load from Ambari should be cleaned away. > On app load, the view should validate the parameters and display error messages in an error section. If there are errors (invalid values, empty strings, etc.), the App should be put in error mode where it does not load further. > There should be an App wide location to easily determine parameters and their values (Maybe a _App.ViewParameter.sliderUser_ etc.). > In the Create App wizard, _Enable Metrics_ action should only be enabled only when {{ganglia.addtional.clusters}} and {{ganglia.host}} are provided. -- This message was sent by Atlassian JIRA (v6.3.4#6332)