Mailing-List: contact dev-help@ambari.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@ambari.apache.org
Content-Type: multipart/alternative;
 boundary="===============8409903262207164708=="
MIME-Version: 1.0
Subject: Re: Review Request 25572: Associating repository latest url for
 deploying cluster using blueprint.
From: "Cabir Zounaidou" <czounaidou@hortonworks.com>
To: "Mahadev Konar" <mahadev@apache.org>,
 "Srimanth Gunturi" <srimanth@hortonworks.com>,
 "Robert Nettleton" <rnettleton@hortonworks.com>,
 "John Speidel" <jspeidel@hortonworks.com>,
 "Erik Bergenholtz" <ebergenholtz@hortonworks.com>,
 "Nate Cole" <ncole@hortonworks.com>
Cc: "Ambari" <dev@ambari.apache.org>,
 "Cabir Zounaidou" <czounaidou@hortonworks.com>
Date: Fri, 19 Sep 2014 19:53:35 -0000
Message-ID: <20140919195335.7800.81561@reviews.apache.org>
Auto-Submitted: auto-generated
Sender: "Cabir Zounaidou" <noreply@reviews.apache.org>
References: <20140919191338.7800.41955@reviews.apache.org>
In-Reply-To: <20140919191338.7800.41955@reviews.apache.org>
Reply-To: "Cabir Zounaidou" <czounaidou@hortonworks.com>

--===============8409903262207164708==
MIME-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 7bit


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/25572/
-----------------------------------------------------------

(Updated Sept. 19, 2014, 7:53 p.m.)


Review request for Ambari, Erik Bergenholtz, John Speidel, Mahadev Konar, Nate Cole, Robert Nettleton, and Srimanth Gunturi.


Changes
-------

Minor fix in the testcase.  No need to set the injector on AmbariMetaInfo as it is already injected.


Bugs: AMBARI-7286
    https://issues.apache.org/jira/browse/AMBARI-7286


Repository: ambari


Description
-------

Steps:
1.  Create a blueprint
{"configurations": [], "host_groups": [
    {"name": "host1",
        "cardinality": "1",
        "components": [
            {"name": "DATANODE" },
            {"name": "SECONDARY_NAMENODE" },
            {"name": "NAMENODE" },
            {"name": "ZOOKEEPER_SERVER" },
            {"name": "ZOOKEEPER_CLIENT" },
            {"name": "HDFS_CLIENT" }
        ]
    }
], "Blueprints": {
    "blueprint_name": "hdfszk",
    "stack_name": "HDP",
    "stack_version": "2.1"
}}

2.  Create a cluster template to deploy using blueprint
{
"configurations": [
{

   "cluster-env":{
       "tag":"version1",
       "properties":{"security_enabled":"false","kerberos_domain": "EXAMPLE.COM","ignore_groupsusers_create": "false", "smokeuser": "ambari-qa", "user_group": "hadoop"}
}
}

],
"blueprint": "hdfszk",
"host_groups": [
    {
        "name": "host1",
        "hosts": [
            { "fqdn": "c6401.ambari.apache.org" }
        ]
    }
]
}

3.  Deploy an instance of cluster using the above cluster template

4.  Verify the URL's in the Admin/repositories page of UI.  It was not be using the latest url specified in the repoinfo.xml of the given stack and version before this fix.


Diffs (updated)
-----

  ambari-server/src/main/java/org/apache/ambari/server/state/stack/LatestRepoCallable.java 47d93f1 
  ambari-server/src/test/java/org/apache/ambari/server/api/services/AmbariMetaInfoTest.java d13e5c8 

Diff: https://reviews.apache.org/r/25572/diff/


Testing
-------

1. Ran the unit tests.  The ClusterResourceProviderTest.java has unit for deploying cluster using blueprint.
2. Manually tested deploying a cluster from the UI
3. Ran the REST-API's to test deploying cluster using blueprint and verified the repository urls.
   3.1 Create a blueprint using the API 
curl -i --user admin:adminhttp://c6401.ambari.apache.org:8080/api/v1/blueprints/blueprint1 -X POST -d @/tmp/myblueprint_template_json -H "X-Requested-By: ambari"
   3.2 Create a cluster from the template which was using the blueprint
curl -i --user admin:admin -H "X-Requested-By: ambari" -X POST -d @/tmp/cluster_blueprint_instance.json  http://c6401.ambari.apache.org:8080/api/v1/clusters/cl1
   3.3 Checked the status of the task until it is completed.
   3.4 Verified in the UI that Admin/repositories page shows up the latest repo url (specified in repoinfo.xml) for the stack selected.
   3.5 Also verified the generated command file (/var/lib/ambari-agent/data/command-x.json) for the latest url.  It sets the baseUrl="http://public-repo-1.hortonworks.com/HDP/centos6/2.x/updates/2.1.5.0\", which is same as the latestBaseUrl.
    :
    :
    "hostLevelParams": {
        "jdk_location": "http://c6401.ambari.apache.org:8080/resources/",
        "ambari_db_rca_password": "mapred",
        "java_home": "/usr/jdk64/jdk1.7.0_45",
        "ambari_db_rca_url": "jdbc:postgresql://c6401.ambari.apache.org/ambarirca",
        "jce_name": "UnlimitedJCEPolicyJDK7.zip",
        "oracle_jdbc_url": "http://c6401.ambari.apache.org:8080/resources//ojdbc6.jar",
        "repo_info": "[{\"baseUrl\":\"http://public-repo-1.hortonworks.com/HDP/centos6/2.x/updates/2.1.5.0\",\"osType\":\"redhat6\",\"repoId\":\"HDP-2.1\",\"repoName\":\"HDP\",\"defaultBaseUrl\":\"http://s3.amazonaws.com/dev.hortonworks.com/HDP/centos6/2.x/updates/2.1.5.0/\",\"latestBaseUrl\":\"http://public-repo-1.hortonworks.com/HDP/centos6/2.x/updates/2.1.5.0\"},{\"baseUrl\":\"http://s3.amazonaws.com/dev.hortonworks.com/HDP-UTILS-1.1.0.19/repos/centos6\",\"osType\":\"redhat6\",\"repoId\":\"HDP-UTILS-1.1.0.19\",\"repoName\":\"HDP-UTILS\",\"defaultBaseUrl\":\"http://s3.amazonaws.com/dev.hortonworks.com/HDP-UTILS-1.1.0.19/repos/centos6\",\"latestBaseUrl\":\"http://s3.amazonaws.com/dev.hortonworks.com/HDP-UTILS-1.1.0.19/repos/centos6\"}]",
        "group_list": "[\"hadoop\",\"users\"]",
        
        :


Thanks,

Cabir Zounaidou


--===============8409903262207164708==--