Return-Path: X-Original-To: apmail-ambari-dev-archive@www.apache.org Delivered-To: apmail-ambari-dev-archive@www.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id E0B16112B7 for ; Fri, 19 Sep 2014 16:45:56 +0000 (UTC) Received: (qmail 71637 invoked by uid 500); 19 Sep 2014 16:45:56 -0000 Delivered-To: apmail-ambari-dev-archive@ambari.apache.org Received: (qmail 71605 invoked by uid 500); 19 Sep 2014 16:45:56 -0000 Mailing-List: contact dev-help@ambari.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@ambari.apache.org Delivered-To: mailing list dev@ambari.apache.org Received: (qmail 71590 invoked by uid 99); 19 Sep 2014 16:45:56 -0000 Received: from reviews-vm.apache.org (HELO reviews.apache.org) (140.211.11.40) by apache.org (qpsmtpd/0.29) with ESMTP; Fri, 19 Sep 2014 16:45:56 +0000 Received: from reviews.apache.org (localhost [127.0.0.1]) by reviews.apache.org (Postfix) with ESMTP id 5DAC91DD84C; Fri, 19 Sep 2014 16:45:54 +0000 (UTC) Content-Type: multipart/alternative; boundary="===============3760622152828140832==" MIME-Version: 1.0 Subject: Re: Review Request 25827: Alerts: add aggregate alert type and calculation From: "Jonathan Hurley" To: "Jonathan Hurley" Cc: "Nate Cole" , "Ambari" Date: Fri, 19 Sep 2014 16:45:54 -0000 Message-ID: <20140919164554.7800.56659@reviews.apache.org> X-ReviewBoard-URL: https://reviews.apache.org Auto-Submitted: auto-generated Sender: "Jonathan Hurley" X-ReviewGroup: Ambari X-ReviewRequest-URL: https://reviews.apache.org/r/25827/ X-Sender: "Jonathan Hurley" References: <20140919152219.7803.43565@reviews.apache.org> In-Reply-To: <20140919152219.7803.43565@reviews.apache.org> Reply-To: "Jonathan Hurley" X-ReviewRequest-Repository: ambari --===============3760622152828140832== MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/25827/#review53959 ----------------------------------------------------------- ambari-server/src/main/java/org/apache/ambari/server/api/services/AmbariMetaInfo.java Here's a nit: == for enums prevents method invocation, possibly saving you a fraction of a millisecond. ambari-server/src/main/java/org/apache/ambari/server/events/listeners/AlertAggregateListener.java Should probably not initialize an @Inject to null. - Jonathan Hurley On Sept. 19, 2014, 11:22 a.m., Nate Cole wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/25827/ > ----------------------------------------------------------- > > (Updated Sept. 19, 2014, 11:22 a.m.) > > > Review request for Ambari and Jonathan Hurley. > > > Bugs: AMBARI-7410 > https://issues.apache.org/jira/browse/AMBARI-7410 > > > Repository: ambari > > > Description > ------- > > Add aggregates > > > Diffs > ----- > > ambari-server/src/main/java/org/apache/ambari/server/api/services/AmbariMetaInfo.java e3e5779 > ambari-server/src/main/java/org/apache/ambari/server/controller/internal/AlertDefinitionResourceProvider.java c63f063 > ambari-server/src/main/java/org/apache/ambari/server/events/listeners/AlertAggregateListener.java PRE-CREATION > ambari-server/src/main/java/org/apache/ambari/server/events/listeners/AlertReceivedListener.java 0f1b49a > ambari-server/src/main/java/org/apache/ambari/server/orm/dao/AlertsDAO.java a274089 > ambari-server/src/main/java/org/apache/ambari/server/orm/entities/AlertCurrentEntity.java c24ac17 > ambari-server/src/main/java/org/apache/ambari/server/orm/entities/AlertDefinitionEntity.java b4b8a44 > ambari-server/src/main/java/org/apache/ambari/server/state/alert/AlertDefinitionFactory.java f16f4a6 > ambari-server/src/main/java/org/apache/ambari/server/state/alert/MetricSource.java 530c1bb > ambari-server/src/main/resources/stacks/HDP/2.0.6/services/HBASE/alerts.json 3958106 > ambari-server/src/main/resources/stacks/HDP/2.0.6/services/HDFS/alerts.json 00286b1 > ambari-server/src/test/java/org/apache/ambari/server/api/services/AmbariMetaInfoTest.java 66c0b3d > ambari-server/src/test/java/org/apache/ambari/server/controller/internal/AlertDefinitionResourceProviderTest.java 7ea2ffe > ambari-server/src/test/java/org/apache/ambari/server/controller/internal/AlertGroupResourceProviderTest.java ddfc75a > ambari-server/src/test/java/org/apache/ambari/server/orm/OrmTestHelper.java a9d126c > ambari-server/src/test/java/org/apache/ambari/server/orm/dao/AlertDefinitionDAOTest.java cdca3dd > ambari-server/src/test/java/org/apache/ambari/server/orm/dao/AlertDispatchDAOTest.java 2c3a876 > ambari-server/src/test/java/org/apache/ambari/server/orm/dao/AlertsDAOTest.java a397da4 > ambari-server/src/test/java/org/apache/ambari/server/state/cluster/AlertDataManagerTest.java bbf7774 > ambari-server/src/test/resources/stacks/HDP/2.0.5/services/HDFS/alerts.json f4a3001 > > Diff: https://reviews.apache.org/r/25827/diff/ > > > Testing > ------- > > [INFO] ------------------------------------------------------------------------ > [INFO] BUILD SUCCESS > [INFO] ------------------------------------------------------------------------ > [INFO] Total time: 22:12.127s > [INFO] Finished at: Fri Sep 19 11:19:30 EDT 2014 > [INFO] Final Memory: 30M/204M > [INFO] ------------------------------------------------------------------------ > > > Thanks, > > Nate Cole > > --===============3760622152828140832==--