Mailing-List: contact dev-help@ambari.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@ambari.apache.org
Content-Type: multipart/alternative;
 boundary="===============7903896988510035546=="
MIME-Version: 1.0
Subject: Re: Review Request 25613: Slider View: Slider view not initializing
 due to long parameter description
From: "Tom Beerbower" <tbeerbower@hortonworks.com>
To: "Srimanth Gunturi" <srimanth@hortonworks.com>
Cc: "Ambari" <dev@ambari.apache.org>,
 "Tom Beerbower" <tbeerbower@hortonworks.com>
Date: Tue, 16 Sep 2014 19:55:44 -0000
Message-ID: <20140916195544.7803.74234@reviews.apache.org>
Auto-Submitted: auto-generated
Sender: "Tom Beerbower" <noreply@reviews.apache.org>
References: <20140913202949.23923.69872@reviews.apache.org>
In-Reply-To: <20140913202949.23923.69872@reviews.apache.org>
Reply-To: "Tom Beerbower" <tbeerbower@hortonworks.com>

--===============7903896988510035546==
MIME-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 8bit


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/25613/
-----------------------------------------------------------

(Updated Sept. 16, 2014, 7:55 p.m.)


Review request for Ambari and Srimanth Gunturi.


Bugs: AMBARI-7254
    https://issues.apache.org/jira/browse/AMBARI-7254


Repository: ambari


Description
-------

Slider view was not initializing because the description of one of the parameters was greater than 255 characters.  

Exception:
{code}
Caused by: java.sql.BatchUpdateException: Batch entry 0 INSERT INTO viewparameter (name, DESCRIPTION, MASKED, REQUIRED, view_name) VALUES ('zookeeper.quorum', 'ZooKeeper quorum location. Typically this is a comma separated list of ZooKeeper hostnames and port numbers. The port number can be got from the clientPort property in the zookeeper-env configuration. For example: zookeeper.host1:2181,zookeeper.host2:2181.', 'N', 'N', 'SLIDER{1.0.0}') was aborted.  Call getNextException to see the cause.
        at org.postgresql.jdbc2.AbstractJdbc2Statement$BatchResultHandler.handleError(AbstractJdbc2Statement.java:2740)
        at org.postgresql.core.v3.QueryExecutorImpl.processResults(QueryExecutorImpl.java:1891)
        at org.postgresql.core.v3.QueryExecutorImpl.execute(QueryExecutorImpl.java:405)
        at org.postgresql.jdbc2.AbstractJdbc2Statement.executeBatch(AbstractJdbc2Statement.java:2889)
        at org.eclipse.persistence.internal.databaseaccess.DatabasePlatform.executeBatch(DatabasePlatform.java:2127)
        at org.eclipse.persistence.internal.databaseaccess.DatabaseAccessor.executeJDK12BatchStatement(DatabaseAccessor.java:871)
{code}

{code}
01:40:54,010 ERROR [pool-1-thread-3] AmbariJpaLocalTxnInterceptor:122 - [DETAILED ERROR] Internal exception (2) :
org.postgresql.util.PSQLException: ERROR: value too long for type character varying(255)
        at org.postgresql.core.v3.QueryExecutorImpl.receiveErrorResponse(QueryExecutorImpl.java:2161)
        at org.postgresql.core.v3.QueryExecutorImpl.processResults(QueryExecutorImpl.java:1890)
        at org.postgresql.core.v3.QueryExecutorImpl.execute(QueryExecutorImpl.java:405)
        at org.postgresql.jdbc2.AbstractJdbc2Statement.executeBatch(AbstractJdbc2Statement.java:2889)
        at org.eclipse.persistence.internal.databaseaccess.DatabasePlatform.executeBatch(DatabasePlatform.java:2127)
        at org.eclipse.persistence.internal.databaseaccess.DatabaseAccessor.executeJDK12BatchStatement(DatabaseAccessor.java:871)
        at org.eclipse.persistence.internal.databaseaccess.ParameterizedSQLBatchWritingMechanism.executeBatchedStatements(ParameterizedSQLBatchWritingMechanism.java:145)
        at org.eclipse.persistence.internal.databaseaccess.ParameterizedSQLBatchWritingMechanism.appendCall(ParameterizedSQLBatchWritingMechanism.java:88)
        at org.eclipse.persistence.internal.databaseaccess.DatabaseAccessor.basicExecuteCall(DatabaseAccessor.java:571)
        at org.eclipse.persistence.internal.databaseaccess.DatabaseAccessor.executeCall(DatabaseAccessor.java:537)
        at org.eclipse.persistence.internal.sessions.AbstractSession.basicExecuteCall(AbstractSession.java:1800)
{code}


Diffs
-----

  ambari-server/src/main/java/org/apache/ambari/server/upgrade/UpgradeCatalog170.java 4a9b83f 
  ambari-server/src/main/resources/Ambari-DDL-MySQL-CREATE.sql 4a6d3ba 
  ambari-server/src/main/resources/Ambari-DDL-Oracle-CREATE.sql 2e6b5c0 
  ambari-server/src/main/resources/Ambari-DDL-Postgres-CREATE.sql 400373e 
  ambari-server/src/main/resources/Ambari-DDL-Postgres-EMBEDDED-CREATE.sql 74e6d1c 

Diff: https://reviews.apache.org/r/25613/diff/


Testing (updated)
-------

All tests pass...

Results :

Tests run: 1986, Failures: 0, Errors: 0, Skipped: 16

….


[INFO] ------------------------------------------------------------------------
[INFO] BUILD SUCCESS
[INFO] ------------------------------------------------------------------------
[INFO] Total time: 34:00.502s
[INFO] Finished at: Sat Sep 13 16:08:23 EDT 2014
[INFO] Final Memory: 45M/326M
[INFO] ------------------------------------------------------------------------


Thanks,

Tom Beerbower


--===============7903896988510035546==--