Return-Path: X-Original-To: apmail-ambari-dev-archive@www.apache.org Delivered-To: apmail-ambari-dev-archive@www.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 1F72011042 for ; Tue, 16 Sep 2014 14:15:39 +0000 (UTC) Received: (qmail 90344 invoked by uid 500); 16 Sep 2014 14:15:39 -0000 Delivered-To: apmail-ambari-dev-archive@ambari.apache.org Received: (qmail 90310 invoked by uid 500); 16 Sep 2014 14:15:39 -0000 Mailing-List: contact dev-help@ambari.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@ambari.apache.org Delivered-To: mailing list dev@ambari.apache.org Received: (qmail 90293 invoked by uid 99); 16 Sep 2014 14:15:38 -0000 Received: from reviews-vm.apache.org (HELO reviews.apache.org) (140.211.11.40) by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 16 Sep 2014 14:15:38 +0000 Received: from reviews.apache.org (localhost [127.0.0.1]) by reviews.apache.org (Postfix) with ESMTP id D172E1DD75D; Tue, 16 Sep 2014 14:15:36 +0000 (UTC) Content-Type: multipart/alternative; boundary="===============2840551097605284742==" MIME-Version: 1.0 Subject: Re: Review Request 25660: Add "exclusive" flag to custom command/custom action requests From: "Dmitro Lisnichenko" To: "Dmytro Sen" Cc: "Dmitro Lisnichenko" , "Ambari" Date: Tue, 16 Sep 2014 14:15:36 -0000 Message-ID: <20140916141536.7803.92340@reviews.apache.org> X-ReviewBoard-URL: https://reviews.apache.org Auto-Submitted: auto-generated Sender: "Dmitro Lisnichenko" X-ReviewGroup: Ambari X-ReviewRequest-URL: https://reviews.apache.org/r/25660/ X-Sender: "Dmitro Lisnichenko" References: <20140916124828.7803.66198@reviews.apache.org> In-Reply-To: <20140916124828.7803.66198@reviews.apache.org> Reply-To: "Dmitro Lisnichenko" X-ReviewRequest-Repository: ambari --===============2840551097605284742== MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit > On Sept. 16, 2014, 12:48 p.m., Dmytro Sen wrote: > > ambari-server/src/main/java/org/apache/ambari/server/upgrade/UpgradeCatalog170.java, line 233 > > > > > > Shouldn't it be boolean.class ? We have a convention to use Integer in such cases as stated at AMBARI-6202 - Dmitro ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/25660/#review53514 ----------------------------------------------------------- On Sept. 16, 2014, 10:54 a.m., Dmitro Lisnichenko wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/25660/ > ----------------------------------------------------------- > > (Updated Sept. 16, 2014, 10:54 a.m.) > > > Review request for Ambari and Dmytro Sen. > > > Bugs: AMBARI-7317 > https://issues.apache.org/jira/browse/AMBARI-7317 > > > Repository: ambari > > > Description > ------- > > The issue is that Update Nagios request may be executed in parallel with start/stop requests in some cases. If Nagios host does not belong to a set of hosts that are affected by start/stop requests, then API user may be able to get a race condition and (sometimes) fake alerts. > > It seems that the straightforward solution for both issues is to implement some flag (like exclusive=true) that would be available for custom actions/custom commands. The flag would forbid running request in parallel with other requests. This flag would be used when issuing Update Nagios request. As a result, race condition would not be possible. > > > Diffs > ----- > > ambari-server/src/main/java/org/apache/ambari/server/actionmanager/ActionScheduler.java 0385686 > ambari-server/src/main/java/org/apache/ambari/server/actionmanager/Request.java 03c4d2e > ambari-server/src/main/java/org/apache/ambari/server/controller/ExecuteActionRequest.java 5e42276 > ambari-server/src/main/java/org/apache/ambari/server/controller/MaintenanceStateHelper.java 059e2c9 > ambari-server/src/main/java/org/apache/ambari/server/controller/internal/RequestResourceProvider.java 3e36ee9 > ambari-server/src/main/java/org/apache/ambari/server/orm/entities/RequestEntity.java a35771e > ambari-server/src/main/java/org/apache/ambari/server/upgrade/UpgradeCatalog170.java 75635cc > ambari-server/src/main/resources/Ambari-DDL-MySQL-CREATE.sql 4a6d3ba > ambari-server/src/main/resources/Ambari-DDL-Oracle-CREATE.sql 2e6b5c0 > ambari-server/src/main/resources/Ambari-DDL-Postgres-CREATE.sql 400373e > ambari-server/src/main/resources/Ambari-DDL-Postgres-EMBEDDED-CREATE.sql 74e6d1c > ambari-server/src/main/resources/properties.json 9471f3d > ambari-server/src/test/java/org/apache/ambari/server/actionmanager/TestActionDBAccessorImpl.java 6d4f056 > ambari-server/src/test/java/org/apache/ambari/server/actionmanager/TestActionScheduler.java c4a88cf > ambari-server/src/test/java/org/apache/ambari/server/controller/AmbariCustomCommandExecutionHelperTest.java a14c86a > ambari-server/src/test/java/org/apache/ambari/server/controller/AmbariManagementControllerTest.java 8a3e270 > ambari-server/src/test/java/org/apache/ambari/server/controller/BackgroundCustomCommandExecutionTest.java 76b9fbc > > Diff: https://reviews.apache.org/r/25660/diff/ > > > Testing > ------- > > [INFO] ------------------------------------------------------------------------ > [INFO] Reactor Summary: > [INFO] > [INFO] Ambari Views ...................................... SUCCESS [7.122s] > [INFO] Ambari Server ..................................... SUCCESS [17:43.658s] > [INFO] ------------------------------------------------------------------------ > [INFO] BUILD SUCCESS > [INFO] ------------------------------------------------------------------------ > [INFO] Total time: 17:51.487s > [INFO] Finished at: Tue Sep 16 13:41:34 FET 2014 > [INFO] Final Memory: 24M/329M > [INFO] ------------------------------------------------------------------------ > > > Thanks, > > Dmitro Lisnichenko > > --===============2840551097605284742==--