Return-Path: X-Original-To: apmail-ambari-dev-archive@www.apache.org Delivered-To: apmail-ambari-dev-archive@www.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 547D0118FB for ; Mon, 15 Sep 2014 18:49:04 +0000 (UTC) Received: (qmail 81222 invoked by uid 500); 15 Sep 2014 18:49:04 -0000 Delivered-To: apmail-ambari-dev-archive@ambari.apache.org Received: (qmail 81193 invoked by uid 500); 15 Sep 2014 18:49:04 -0000 Mailing-List: contact dev-help@ambari.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@ambari.apache.org Delivered-To: mailing list dev@ambari.apache.org Received: (qmail 81180 invoked by uid 99); 15 Sep 2014 18:49:03 -0000 Received: from reviews-vm.apache.org (HELO reviews.apache.org) (140.211.11.40) by apache.org (qpsmtpd/0.29) with ESMTP; Mon, 15 Sep 2014 18:49:03 +0000 Received: from reviews.apache.org (localhost [127.0.0.1]) by reviews.apache.org (Postfix) with ESMTP id 0F6311DB835; Mon, 15 Sep 2014 18:49:02 +0000 (UTC) Content-Type: multipart/alternative; boundary="===============0637112891440800977==" MIME-Version: 1.0 Subject: Re: Review Request 25654: Views : change view status names From: "Jonathan Hurley" To: "Jonathan Hurley" Cc: "Tom Beerbower" , "Ambari" Date: Mon, 15 Sep 2014 18:49:02 -0000 Message-ID: <20140915184902.7803.22381@reviews.apache.org> X-ReviewBoard-URL: https://reviews.apache.org Auto-Submitted: auto-generated Sender: "Jonathan Hurley" X-ReviewGroup: Ambari X-ReviewRequest-URL: https://reviews.apache.org/r/25654/ X-Sender: "Jonathan Hurley" References: <20140915183426.7800.61969@reviews.apache.org> In-Reply-To: <20140915183426.7800.61969@reviews.apache.org> Reply-To: "Jonathan Hurley" X-ReviewRequest-Repository: ambari --===============0637112891440800977== MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/25654/#review53372 ----------------------------------------------------------- ambari-server/src/main/java/org/apache/ambari/server/view/ViewRegistry.java Do we care if the text says "Loading" or "Deploying"? - Jonathan Hurley On Sept. 15, 2014, 2:34 p.m., Tom Beerbower wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/25654/ > ----------------------------------------------------------- > > (Updated Sept. 15, 2014, 2:34 p.m.) > > > Review request for Ambari and Jonathan Hurley. > > > Bugs: AMBARI-7314 > https://issues.apache.org/jira/browse/AMBARI-7314 > > > Repository: ambari > > > Description > ------- > > The view status names LOADING and LOADED should be changed to DEPLOYING and DEPLOYED to be inline with the current view event onDeploy. > > > Diffs > ----- > > ambari-server/src/main/java/org/apache/ambari/server/controller/internal/AmbariPrivilegeResourceProvider.java 85e5906 > ambari-server/src/main/java/org/apache/ambari/server/controller/internal/ViewInstanceResourceProvider.java 09b63a4 > ambari-server/src/main/java/org/apache/ambari/server/controller/internal/ViewPermissionResourceProvider.java 5f025d9 > ambari-server/src/main/java/org/apache/ambari/server/controller/internal/ViewPrivilegeResourceProvider.java f2f488a > ambari-server/src/main/java/org/apache/ambari/server/orm/entities/ViewEntity.java b6ec922 > ambari-server/src/main/java/org/apache/ambari/server/view/ViewRegistry.java 1c6c792 > ambari-server/src/test/java/org/apache/ambari/server/controller/internal/AmbariPrivilegeResourceProviderTest.java fa342fe > ambari-server/src/test/java/org/apache/ambari/server/controller/internal/ViewInstanceResourceProviderTest.java 4a429b6 > ambari-server/src/test/java/org/apache/ambari/server/controller/internal/ViewPermissionResourceProviderTest.java eebe0d3 > ambari-server/src/test/java/org/apache/ambari/server/controller/internal/ViewPrivilegeResourceProviderTest.java 0e9d3d6 > ambari-server/src/test/java/org/apache/ambari/server/orm/entities/ViewEntityTest.java be0d3a6 > ambari-server/src/test/java/org/apache/ambari/server/view/ViewRegistryTest.java 0915325 > ambari-views/src/main/java/org/apache/ambari/view/ViewDefinition.java 18b86ff > > Diff: https://reviews.apache.org/r/25654/diff/ > > > Testing > ------- > > All existing tests pass. > > > Thanks, > > Tom Beerbower > > --===============0637112891440800977==--