Return-Path: X-Original-To: apmail-ambari-dev-archive@www.apache.org Delivered-To: apmail-ambari-dev-archive@www.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id A11FB11B98 for ; Fri, 12 Sep 2014 15:13:47 +0000 (UTC) Received: (qmail 10514 invoked by uid 500); 12 Sep 2014 15:13:47 -0000 Delivered-To: apmail-ambari-dev-archive@ambari.apache.org Received: (qmail 10484 invoked by uid 500); 12 Sep 2014 15:13:47 -0000 Mailing-List: contact dev-help@ambari.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@ambari.apache.org Delivered-To: mailing list dev@ambari.apache.org Received: (qmail 10471 invoked by uid 99); 12 Sep 2014 15:13:46 -0000 Received: from reviews-vm.apache.org (HELO reviews.apache.org) (140.211.11.40) by apache.org (qpsmtpd/0.29) with ESMTP; Fri, 12 Sep 2014 15:13:46 +0000 Received: from reviews.apache.org (localhost [127.0.0.1]) by reviews.apache.org (Postfix) with ESMTP id F33BE1DD6ED; Fri, 12 Sep 2014 15:13:44 +0000 (UTC) Content-Type: multipart/alternative; boundary="===============4314281135248654033==" MIME-Version: 1.0 Subject: Re: Review Request 25583: Alerts: add metric- and script-based alert types From: "Jonathan Hurley" To: "Jonathan Hurley" Cc: "Nate Cole" , "Ambari" Date: Fri, 12 Sep 2014 15:13:44 -0000 Message-ID: <20140912151344.23923.68889@reviews.apache.org> X-ReviewBoard-URL: https://reviews.apache.org Auto-Submitted: auto-generated Sender: "Jonathan Hurley" X-ReviewGroup: Ambari X-ReviewRequest-URL: https://reviews.apache.org/r/25583/ X-Sender: "Jonathan Hurley" References: <20140912144646.23924.90517@reviews.apache.org> In-Reply-To: <20140912144646.23924.90517@reviews.apache.org> Reply-To: "Jonathan Hurley" X-ReviewRequest-Repository: ambari --===============4314281135248654033== MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/25583/#review53177 ----------------------------------------------------------- ambari-agent/src/main/python/ambari_agent/AlertSchedulerHandler.py Will this eventually use the same level as the rest of the agent? ambari-agent/src/main/python/ambari_agent/alerts/metric_alert.py Why not just throw an exception when there's no port that can be extracted? Isn't a port always required for a metric check? - Jonathan Hurley On Sept. 12, 2014, 10:46 a.m., Nate Cole wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/25583/ > ----------------------------------------------------------- > > (Updated Sept. 12, 2014, 10:46 a.m.) > > > Review request for Ambari and Jonathan Hurley. > > > Bugs: AMBARI-7282 > https://issues.apache.org/jira/browse/AMBARI-7282 > > > Repository: ambari > > > Description > ------- > > Added metric and script alerts. Also added saving the latest text from a given alerts > > > Diffs > ----- > > ambari-agent/src/main/python/ambari_agent/AlertSchedulerHandler.py e987dae > ambari-agent/src/main/python/ambari_agent/Controller.py 0ceeeff > ambari-agent/src/main/python/ambari_agent/alerts/base_alert.py adb872a > ambari-agent/src/main/python/ambari_agent/alerts/metric_alert.py PRE-CREATION > ambari-agent/src/main/python/ambari_agent/alerts/script_alert.py PRE-CREATION > ambari-agent/src/test/python/ambari_agent/TestAlerts.py 6674fdf > ambari-agent/src/test/python/ambari_agent/dummy_files/definitions.json 4894b62 > ambari-agent/src/test/python/ambari_agent/dummy_files/test_script.py PRE-CREATION > ambari-server/src/main/java/org/apache/ambari/server/controller/internal/AlertResourceProvider.java 639a02f > ambari-server/src/main/java/org/apache/ambari/server/controller/internal/AlertSummaryPropertyProvider.java 438d471 > ambari-server/src/main/java/org/apache/ambari/server/state/alert/MetricSource.java 8bdd2ba > ambari-server/src/main/java/org/apache/ambari/server/state/cluster/AlertDataManager.java 4670d3b > ambari-server/src/main/resources/stacks/HDP/2.0.6/services/HDFS/alerts.json 7f863a7 > > Diff: https://reviews.apache.org/r/25583/diff/ > > > Testing > ------- > > [INFO] Ambari Main ....................................... SUCCESS [2.467s] > [INFO] Apache Ambari Project POM ......................... SUCCESS [0.266s] > [INFO] Ambari Web ........................................ SUCCESS [13.644s] > [INFO] Ambari Views ...................................... SUCCESS [4.827s] > [INFO] Ambari Admin View ................................. SUCCESS [10.279s] > [INFO] Ambari Server ..................................... SUCCESS [26:04.212s] > [INFO] Ambari Agent ...................................... SUCCESS [8.333s] > [INFO] Ambari Client ..................................... SUCCESS [0.031s] > [INFO] Ambari Python Client .............................. SUCCESS [0.488s] > [INFO] Ambari Groovy Client .............................. SUCCESS [13.366s] > [INFO] Ambari Shell ...................................... SUCCESS [0.038s] > [INFO] Ambari Python Shell ............................... SUCCESS [0.063s] > [INFO] Ambari Groovy Shell ............................... SUCCESS [7.271s] > [INFO] ------------------------------------------------------------------------ > [INFO] BUILD SUCCESS > [INFO] ------------------------------------------------------------------------ > [INFO] Total time: 27:05.953s > [INFO] Finished at: Fri Sep 12 10:22:01 EDT 2014 > [INFO] Final Memory: 39M/196M > [INFO] ------------------------------------------------------------------------ > > > Thanks, > > Nate Cole > > --===============4314281135248654033==--