Return-Path: X-Original-To: apmail-ambari-dev-archive@www.apache.org Delivered-To: apmail-ambari-dev-archive@www.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id EB39111450 for ; Thu, 11 Sep 2014 18:28:18 +0000 (UTC) Received: (qmail 59841 invoked by uid 500); 11 Sep 2014 18:28:18 -0000 Delivered-To: apmail-ambari-dev-archive@ambari.apache.org Received: (qmail 59813 invoked by uid 500); 11 Sep 2014 18:28:18 -0000 Mailing-List: contact dev-help@ambari.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@ambari.apache.org Delivered-To: mailing list dev@ambari.apache.org Received: (qmail 59796 invoked by uid 99); 11 Sep 2014 18:28:18 -0000 Received: from reviews-vm.apache.org (HELO reviews.apache.org) (140.211.11.40) by apache.org (qpsmtpd/0.29) with ESMTP; Thu, 11 Sep 2014 18:28:18 +0000 Received: from reviews.apache.org (localhost [127.0.0.1]) by reviews.apache.org (Postfix) with ESMTP id 219DC1DD66D; Thu, 11 Sep 2014 18:28:17 +0000 (UTC) Content-Type: multipart/alternative; boundary="===============3171668018403531934==" MIME-Version: 1.0 Subject: Re: Review Request 25542: Alerts: DDL for alert_current requires latest_text From: "Jonathan Hurley" To: "Jonathan Hurley" Cc: "Nate Cole" , "Ambari" Date: Thu, 11 Sep 2014 18:28:17 -0000 Message-ID: <20140911182817.23923.70088@reviews.apache.org> X-ReviewBoard-URL: https://reviews.apache.org Auto-Submitted: auto-generated Sender: "Jonathan Hurley" X-ReviewGroup: Ambari X-ReviewRequest-URL: https://reviews.apache.org/r/25542/ X-Sender: "Jonathan Hurley" References: <20140911160822.23924.62432@reviews.apache.org> In-Reply-To: <20140911160822.23924.62432@reviews.apache.org> Reply-To: "Jonathan Hurley" X-ReviewRequest-Repository: ambari --===============3171668018403531934== MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/25542/#review53080 ----------------------------------------------------------- ambari-server/src/main/java/org/apache/ambari/server/upgrade/UpgradeCatalog170.java On upgrade, latest_text should be marked as nullable to match the DDL. - Jonathan Hurley On Sept. 11, 2014, 12:08 p.m., Nate Cole wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/25542/ > ----------------------------------------------------------- > > (Updated Sept. 11, 2014, 12:08 p.m.) > > > Review request for Ambari and Jonathan Hurley. > > > Bugs: AMBARI-7263 > https://issues.apache.org/jira/browse/AMBARI-7263 > > > Repository: ambari > > > Description > ------- > > Need the latest_text on a current record, as that data may have the latest-and-greatest coming from an agent, even though there would be no new history record. > > > Diffs > ----- > > ambari-server/src/main/java/org/apache/ambari/server/orm/entities/AlertCurrentEntity.java cde61f2 > ambari-server/src/main/java/org/apache/ambari/server/upgrade/UpgradeCatalog170.java 17750f9 > ambari-server/src/main/resources/Ambari-DDL-MySQL-CREATE.sql 356ef0c > ambari-server/src/main/resources/Ambari-DDL-Oracle-CREATE.sql ecaf220 > ambari-server/src/main/resources/Ambari-DDL-Postgres-CREATE.sql f0ac53a > ambari-server/src/main/resources/Ambari-DDL-Postgres-EMBEDDED-CREATE.sql 6e82ae1 > ambari-server/src/test/java/org/apache/ambari/server/upgrade/UpgradeCatalog170Test.java d3d7f7c > > Diff: https://reviews.apache.org/r/25542/diff/ > > > Testing > ------- > > [INFO] ------------------------------------------------------------------------ > [INFO] BUILD SUCCESS > [INFO] ------------------------------------------------------------------------ > [INFO] Total time: 20:41.861s > [INFO] Finished at: Thu Sep 11 12:01:26 EDT 2014 > [INFO] Final Memory: 21M/219M > [INFO] ------------------------------------------------------------------------ > > > Thanks, > > Nate Cole > > --===============3171668018403531934==--