ambari-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Dmitro Lisnichenko" <dlysniche...@hortonworks.com>
Subject Re: Review Request 26184: Clean up JMXPropertyProvider hacks for STORM metrics
Date Tue, 30 Sep 2014 18:21:47 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/26184/#review54994
-----------------------------------------------------------



ambari-server/src/main/java/org/apache/ambari/server/controller/jmx/JMXPropertyProvider.java
<https://reviews.apache.org/r/26184/#comment95321>

    Let's remove that


- Dmitro Lisnichenko


On Sept. 30, 2014, 6:16 p.m., Andrew Onischuk wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/26184/
> -----------------------------------------------------------
> 
> (Updated Sept. 30, 2014, 6:16 p.m.)
> 
> 
> Review request for Ambari and Dmitro Lisnichenko.
> 
> 
> Bugs: AMBARI-4881
>     https://issues.apache.org/jira/browse/AMBARI-4881
> 
> 
> Repository: ambari
> 
> 
> Description
> -------
> 
> Clean up a JMXPropertyProvider hacks for STORM metrics  
> Also include comments from <https://reviews.apache.org/r/18521>
> 
> 
> Diffs
> -----
> 
>   ambari-server/src/main/java/org/apache/ambari/server/controller/internal/AbstractProviderModule.java
fc60210 
>   ambari-server/src/main/java/org/apache/ambari/server/controller/internal/ResourceImpl.java
15fb961 
>   ambari-server/src/main/java/org/apache/ambari/server/controller/internal/StackDefinedPropertyProvider.java
51c7565 
>   ambari-server/src/main/java/org/apache/ambari/server/controller/jmx/JMXHostProvider.java
12f3725 
>   ambari-server/src/main/java/org/apache/ambari/server/controller/jmx/JMXPropertyProvider.java
ca016f5 
>   ambari-server/src/main/java/org/apache/ambari/server/controller/metrics/MetricsHostProvider.java
PRE-CREATION 
>   ambari-server/src/main/java/org/apache/ambari/server/controller/metrics/MetricsProvider.java
PRE-CREATION 
>   ambari-server/src/main/java/org/apache/ambari/server/controller/metrics/RestMetricsPropertyProvider.java
PRE-CREATION 
>   ambari-server/src/main/resources/stacks/HDP/2.1/services/STORM/metrics.json 83e27d1

>   ambari-server/src/test/java/org/apache/ambari/server/controller/internal/StackDefinedPropertyProviderTest.java
2a086ae 
>   ambari-server/src/test/java/org/apache/ambari/server/controller/jmx/JMXPropertyProviderTest.java
24734f8 
>   ambari-server/src/test/java/org/apache/ambari/server/controller/metrics/JMXPropertyProviderTest.java
PRE-CREATION 
>   ambari-server/src/test/resources/stacks/HDP/2.1.1/services/STORM/metrics.json 59bec39

> 
> Diff: https://reviews.apache.org/r/26184/diff/
> 
> 
> Testing
> -------
> 
> mvn clean test
> 
> 
> Thanks,
> 
> Andrew Onischuk
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message