ambari-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Dmytro Sen" <d...@hortonworks.com>
Subject Re: Review Request 26114: Wrong hive client configs
Date Mon, 29 Sep 2014 11:37:20 GMT


> On Сен. 29, 2014, 11:30 д.п., Dmytro Sen wrote:
> > Please add the second reviewer

Why don't we have the same hive-site.xml for all components? If the only difference between
client and master componets is a "javax.jdo.option.ConnectionPassword" presence, we could
specify this property as a command line option for hive-server start command, but not store
in hive-site.xml. We already handle other properties like "hive.security.authenticator.manager"
accordingly


- Dmytro


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/26114/#review54802
-----------------------------------------------------------


On Сен. 27, 2014, 10:17 д.п., Andrew Onischuk wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/26114/
> -----------------------------------------------------------
> 
> (Updated Сен. 27, 2014, 10:17 д.п.)
> 
> 
> Review request for Ambari and Dmytro Sen.
> 
> 
> Bugs: AMBARI-7533
>     https://issues.apache.org/jira/browse/AMBARI-7533
> 
> 
> Repository: ambari
> 
> 
> Description
> -------
> 
> After BUG - 18014 solved we have got a situation when hive client configs
> (stored in /etc/hive/conf/) are overwritten with server params. This leads to  
> 1\.
> 
>     
>     
>     
>         <property>
>           <name>javax.jdo.option.ConnectionPassword</name>
>           <value>12</value>
>         </property>
>     
> 
> present in client's hive-site.xml  
> 2\. wrong client HIVE_CONF_DIR param
> 
>     
>     
>     
>     export HIVE_CONF_DIR=/etc/hive/conf.server
>     
> 
> 
> Diffs
> -----
> 
>   ambari-agent/src/main/python/ambari_agent/ActionQueue.py 476955f 
>   ambari-agent/src/main/python/ambari_agent/ActualConfigHandler.py a038d8c 
>   ambari-agent/src/test/python/ambari_agent/TestActionQueue.py ff165b7 
>   ambari-agent/src/test/python/ambari_agent/TestActualConfigHandler.py 07d0171 
>   ambari-server/src/main/java/org/apache/ambari/server/agent/ExecutionCommand.java 38f9669

>   ambari-server/src/main/java/org/apache/ambari/server/api/util/StackExtensionHelper.java
fe6c6bc 
>   ambari-server/src/main/java/org/apache/ambari/server/controller/AmbariManagementControllerImpl.java
8c0dfeb 
>   ambari-server/src/main/java/org/apache/ambari/server/state/ComponentInfo.java a23b3c3

>   ambari-server/src/main/resources/stacks/HDP/1.3.2/services/HIVE/metainfo.xml 1079cf7

>   ambari-server/src/main/resources/stacks/HDP/1.3.2/services/HIVE/package/scripts/hive.py
3894ddc 
>   ambari-server/src/main/resources/stacks/HDP/2.0.6/services/HIVE/metainfo.xml 6fb1500

>   ambari-server/src/main/resources/stacks/HDP/2.0.6/services/HIVE/package/scripts/hive.py
e6e5eb8 
>   ambari-server/src/test/java/org/apache/ambari/server/controller/AmbariManagementControllerTest.java
ae0becf 
>   ambari-server/src/test/python/stacks/1.3.2/HIVE/test_hive_client.py 13b6772 
>   ambari-server/src/test/python/stacks/1.3.2/HIVE/test_hive_metastore.py 125aa9e 
>   ambari-server/src/test/python/stacks/1.3.2/HIVE/test_hive_server.py ee00bf9 
>   ambari-server/src/test/python/stacks/2.0.6/HIVE/test_hive_client.py 407e0b8 
>   ambari-server/src/test/python/stacks/2.0.6/HIVE/test_hive_metastore.py ebf4721 
>   ambari-server/src/test/python/stacks/2.0.6/HIVE/test_hive_server.py 7122e7b 
>   ambari-server/src/test/python/stacks/2.1/HIVE/test_hive_metastore.py 72da429 
>   ambari-server/src/test/resources/stacks/HDP/2.0.5/services/HIVE/metainfo.xml 5145ef2

>   ambari-server/src/test/resources/stacks/HDP/2.0.7/services/HIVE/metainfo.xml d6d1a34

> 
> Diff: https://reviews.apache.org/r/26114/diff/
> 
> 
> Testing
> -------
> 
> mvn clean test
> 
> 
> Thanks,
> 
> Andrew Onischuk
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message