ambari-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Jonathan Hurley" <jhur...@hortonworks.com>
Subject Review Request 26003: Alerts: data collection starts on install before config values are available
Date Wed, 24 Sep 2014 19:59:46 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/26003/
-----------------------------------------------------------

Review request for Ambari and Nate Cole.


Bugs: AMBARI-7480
    https://issues.apache.org/jira/browse/AMBARI-7480


Repository: ambari


Description
-------

Configuration properties should exist on all AlertDefinitionCommands sent to the agents. Additionally,
alert definitions that are aggregates need to register with the system in order to run after
a cluster install.


Diffs
-----

  ambari-server/src/main/java/org/apache/ambari/server/agent/AlertDefinitionCommand.java 5ae1741352711c726d581e55e0ddfb202cb27074

  ambari-server/src/main/java/org/apache/ambari/server/agent/HeartBeatHandler.java a3663019299ffd6b234bc3c1965fd2e6a5f8802c

  ambari-server/src/main/java/org/apache/ambari/server/api/services/AmbariMetaInfo.java ec53afca0a9049643621d437d88e6d1ccd71cb02

  ambari-server/src/main/java/org/apache/ambari/server/controller/ControllerModule.java cfab1f825b7db6422107f0efad478680039991b5

  ambari-server/src/main/java/org/apache/ambari/server/controller/internal/AlertDefinitionResourceProvider.java
7cb9886dd6f3dead8e707f400c753313b492356f 
  ambari-server/src/main/java/org/apache/ambari/server/events/AlertDefinitionRegistrationEvent.java
PRE-CREATION 
  ambari-server/src/main/java/org/apache/ambari/server/events/AmbariEvent.java dda18c78c41cd1471e1cbc5219262d13ea5cd7a1

  ambari-server/src/main/java/org/apache/ambari/server/events/ClusterEvent.java PRE-CREATION

  ambari-server/src/main/java/org/apache/ambari/server/events/ServiceEvent.java 5e014312816d4c4b4b67789a39c7c64cf92a4bfe

  ambari-server/src/main/java/org/apache/ambari/server/events/listeners/AlertAggregateListener.java
8340c264cfed57f1e2eabff1f9b0f157a7dd2b64 
  ambari-server/src/main/java/org/apache/ambari/server/events/listeners/AlertLifecycleListener.java
PRE-CREATION 
  ambari-server/src/main/java/org/apache/ambari/server/orm/dao/AlertDefinitionDAO.java 570f26840016ed7ce63c750a8b37f433ee511fe3

  ambari-server/src/main/java/org/apache/ambari/server/state/alert/AggregateDefinitionMapping.java
PRE-CREATION 
  ambari-server/src/main/java/org/apache/ambari/server/state/alert/AlertDefinition.java f227c0abd001f3f5207c3e4e912b9f2e6a4b1c40

  ambari-server/src/main/java/org/apache/ambari/server/state/alert/AlertDefinitionFactory.java
f8e44bde0f7841434a7997e2b710c657ecf8ece9 
  ambari-server/src/main/java/org/apache/ambari/server/state/alert/AlertDefinitionHash.java
0a1c73a9bd368f748ebb15d174836cdc55ed8311 
  ambari-server/src/test/java/org/apache/ambari/server/controller/internal/AlertGroupResourceProviderTest.java
d2ce6fbc213befd30339f9d6c77836acb7ea17a1 
  ambari-server/src/test/java/org/apache/ambari/server/orm/OrmTestHelper.java 08cd7b83aaca990c3caa040398cbe2a5604bdee5

  ambari-server/src/test/java/org/apache/ambari/server/orm/dao/AlertDefinitionDAOTest.java
3e20cd66fb3d76e4c16b33c2b8b46ec80f1d494c 
  ambari-server/src/test/java/org/apache/ambari/server/orm/dao/AlertDispatchDAOTest.java 7f4deda3e84c6da1e70e9fd2e49d04a02ee96ce1

  ambari-server/src/test/java/org/apache/ambari/server/orm/dao/AlertsDAOTest.java 6e4d4af929fb3c0f5df9dd1a2cd2fae48d61cd02

  ambari-server/src/test/java/org/apache/ambari/server/state/cluster/AlertDataManagerTest.java
00ba942f125fdc44bfdeb1bee1a4f83ec208a492 

Diff: https://reviews.apache.org/r/26003/diff/


Testing
-------

mvn clean test


Thanks,

Jonathan Hurley


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message