ambari-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Andrew Onischuk" <aonis...@hortonworks.com>
Subject Review Request 25838: Properties from Xml should be automatically added during upgrade
Date Fri, 19 Sep 2014 17:49:49 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/25838/
-----------------------------------------------------------

Review request for Ambari and Vitalyi Brodetskyi.


Bugs: AMBARI-7415
    https://issues.apache.org/jira/browse/AMBARI-7415


Repository: ambari


Description
-------

Currently we have some values of properties hardcoded in upgradeCatalog, and
if they are changed in xml configs, it's error prone since after upgrade it
will have different values, and it's hard to detect.

For example currenlty we have all the contents of oozie-log4j hardcoded in
java code.


Diffs
-----

  ambari-server/src/main/java/org/apache/ambari/server/state/ConfigHelper.java 191549b 
  ambari-server/src/main/java/org/apache/ambari/server/upgrade/AbstractUpgradeCatalog.java
a53159c 
  ambari-server/src/main/java/org/apache/ambari/server/upgrade/UpgradeCatalog161.java a4bb2b2

  ambari-server/src/main/java/org/apache/ambari/server/upgrade/UpgradeCatalog170.java a3198c1

  ambari-server/src/test/java/org/apache/ambari/server/upgrade/UpgradeCatalog161Test.java
4315e2c 
  ambari-server/src/test/java/org/apache/ambari/server/upgrade/UpgradeCatalog170Test.java
6732455 

Diff: https://reviews.apache.org/r/25838/diff/


Testing
-------

mvn clean test


Thanks,

Andrew Onischuk


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message