ambari-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Nate Cole" <nc...@hortonworks.com>
Subject Re: Review Request 25698: Alerts: Create Default AlertGroup When Service Is Installed
Date Tue, 16 Sep 2014 17:30:34 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/25698/#review53547
-----------------------------------------------------------

Ship it!


Ship It!

- Nate Cole


On Sept. 16, 2014, 12:49 p.m., Jonathan Hurley wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/25698/
> -----------------------------------------------------------
> 
> (Updated Sept. 16, 2014, 12:49 p.m.)
> 
> 
> Review request for Ambari and Nate Cole.
> 
> 
> Bugs: AMBARI-7336
>     https://issues.apache.org/jira/browse/AMBARI-7336
> 
> 
> Repository: ambari
> 
> 
> Description
> -------
> 
> Removed tightly coupled alert code from ServiceImpl and replaced with Guava's EventBus.
Subscribers to the new ServiceEvent instances now handle the insertion of AlertDefinitionEntity
and AlertGroupEntity into the database.
> 
> 
> Diffs
> -----
> 
>   ambari-server/src/main/java/org/apache/ambari/server/controller/ControllerModule.java
841376235a8ca1ea2d3067c710cc79cbbf61ea6b 
>   ambari-server/src/main/java/org/apache/ambari/server/events/AlertEvent.java a75477d70f1d5550c7c4fab526c9f24ef79a28ed

>   ambari-server/src/main/java/org/apache/ambari/server/events/AmbariEvent.java PRE-CREATION

>   ambari-server/src/main/java/org/apache/ambari/server/events/ServiceEvent.java PRE-CREATION

>   ambari-server/src/main/java/org/apache/ambari/server/events/ServiceInstalledEvent.java
PRE-CREATION 
>   ambari-server/src/main/java/org/apache/ambari/server/events/listeners/AlertReceivedListener.java
1bdd7e2f3c119c5f318f2826244839773f4bce1b 
>   ambari-server/src/main/java/org/apache/ambari/server/events/listeners/AlertServiceStateListener.java
PRE-CREATION 
>   ambari-server/src/main/java/org/apache/ambari/server/events/listeners/AlertStateChangedListener.java
a327110e6cee46abad973a9f63af5f041a5b3904 
>   ambari-server/src/main/java/org/apache/ambari/server/events/publishers/AlertEventPublisher.java
e42e317aa840f140d0263bb85d451cef984f9535 
>   ambari-server/src/main/java/org/apache/ambari/server/events/publishers/AmbariEventPublisher.java
PRE-CREATION 
>   ambari-server/src/main/java/org/apache/ambari/server/state/ServiceImpl.java b2b84fc178481fd0550c0182608fd3fd23a91ab1

>   ambari-server/src/test/java/org/apache/ambari/server/state/alerts/AlertEventPublisherTest.java
PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/25698/diff/
> 
> 
> Testing
> -------
> 
> mvn clean test
> 
> [INFO] ------------------------------------------------------------------------
> [INFO] BUILD SUCCESS
> [INFO] ------------------------------------------------------------------------
> [INFO] Total time: 18:52 min
> [INFO] Finished at: 2014-09-16T12:49:20-04:00
> [INFO] Final Memory: 29M/221M
> [INFO] ------------------------------------------------------------------------
> 
> 
> Thanks,
> 
> Jonathan Hurley
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message