ambari-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Tom Beerbower" <tbeerbo...@hortonworks.com>
Subject Re: Review Request 25596: Views : Delete view instance causes auto sign out
Date Mon, 15 Sep 2014 15:19:12 GMT


> On Sept. 15, 2014, 3:04 p.m., Alejandro Fernandez wrote:
> > ambari-server/src/main/java/org/apache/ambari/server/controller/AmbariHandlerList.java,
line 139
> > <https://reviews.apache.org/r/25596/diff/1/?file=688042#file688042line139>
> >
> >     What happens when the following happens,
> >     add view foo, remove it, repeat?
> >     A second handler is added, but what happens to the first handler?

Thanks for reviewing.  I've updated the diff.  I think that you are looking at revision 1
which was mostly undone with revision 2.  Your question did make me realize that I wasn't
removing the handler from the member handlerMap in removeViewInstance().  Is that what you
were pointing out?  I just updated with revision 3 that fixes it.  When you remove a handler
(WebAppContext), it should be removed from the underlying Jetty HandlerCollection as well
as the member handlerMap.  This should stop the WebAppContext without stopping the shared
SessionManager.  The WebAppContext should no longer be referenced and will ultimately be GC'd.


- Tom


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/25596/#review53341
-----------------------------------------------------------


On Sept. 15, 2014, 3:11 p.m., Tom Beerbower wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/25596/
> -----------------------------------------------------------
> 
> (Updated Sept. 15, 2014, 3:11 p.m.)
> 
> 
> Review request for Ambari, Alejandro Fernandez, Nate Cole, and Sid Wagle.
> 
> 
> Bugs: AMBARI-7289
>     https://issues.apache.org/jira/browse/AMBARI-7289
> 
> 
> Repository: ambari
> 
> 
> Description
> -------
> 
> Steps :
> 
> 1 Login as admin
> 2 Create new view instance for any view
> 3 Delete the new view instance
> 
> This will redirect to the login page and you will no longer be logged in.
> 
> 
> Diffs
> -----
> 
>   ambari-server/src/main/java/org/apache/ambari/server/controller/AmbariHandlerList.java
6a831f8 
> 
> Diff: https://reviews.apache.org/r/25596/diff/
> 
> 
> Testing
> -------
> 
> Manual tests.
> 
> All existing tests pass.
> 
> Results :
> 
> Tests run: 1986, Failures: 0, Errors: 0, Skipped: 16
> 
> ...
> 
> [INFO] ------------------------------------------------------------------------
> [INFO] BUILD SUCCESS
> [INFO] ------------------------------------------------------------------------
> [INFO] Total time: 34:53.921s
> [INFO] Finished at: Fri Sep 12 17:14:22 EDT 2014
> [INFO] Final Memory: 45M/330M
> [INFO] ------------------------------------------------------------------------
> 
> 
> Thanks,
> 
> Tom Beerbower
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message